sdk: Fix empty-cache handling in LocalFileIdentifiableStore#463
Merged
s-heppner merged 1 commit intoeclipse-basyx:developfrom Feb 25, 2026
Merged
sdk: Fix empty-cache handling in LocalFileIdentifiableStore#463s-heppner merged 1 commit intoeclipse-basyx:developfrom
s-heppner merged 1 commit intoeclipse-basyx:developfrom
Conversation
Previously, the `_object_cache` of the `LocalFileIdentifiableStore` was initialised empty. Calling `discard()` immediately after store initialisation raised a `KeyError` if the Identifiable to delete existed on disk but had not yet been loaded into the in-memory cache. This adds explicit handling of missing cache entries in `discard()`, preventing errors when a key is not present in the in-memory cache. Moreover, a corresponding regression test is added. Finally, the interim empty-cache workaround in `sync()` is removed. Fixes eclipse-basyx#438
s-heppner
approved these changes
Feb 25, 2026
Member
s-heppner
left a comment
s-heppner
left a comment
There was a problem hiding this comment.
This adds explicit handling of missing cache entries in
discard().
This is a very fancy way of saying we now ignore missing cache entries :D
As far as I can see, this is the correct way of handling these, though.
s-heppner
approved these changes
Feb 25, 2026
Member
s-heppner
left a comment
s-heppner
left a comment
There was a problem hiding this comment.
This adds explicit handling of missing cache entries in
discard().
This is a very fancy way of saying we now ignore missing cache entries :D
As far as I can see, this is the correct way of handling these, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
_object_cacheof theLocalFileIdentifiableStorewas initialised empty. Callingdiscard()immediately after store initialisation raised aKeyErrorif the Identifiable to delete existed on disk but had not yet been loaded into the in-memory cache.This adds explicit handling of missing cache entries in
discard(), preventing errors when a key is not present in the in-memory cache. Moreover, a corresponding regression test is added. Finally, the interim empty-cache workaround insync()is removed.Fixes #438