etc/scripts/set_copyright_year.sh: Fix exit bug and check LICENSE#464
Merged
s-heppner merged 2 commits intoeclipse-basyx:developfrom Feb 25, 2026
Merged
etc/scripts/set_copyright_year.sh: Fix exit bug and check LICENSE#464s-heppner merged 2 commits intoeclipse-basyx:developfrom
s-heppner merged 2 commits intoeclipse-basyx:developfrom
Conversation
Previously, the `EXIT_CODE` of the copyright year check was hardcoded to the value 0, causing the CI to pass unconditionally. This fixes the bug by coupling the `EXIT_CODE` to the result of the copyright year check. Moreover, the check has been extended to additionally verify the copyright year of the `LICENSE` file. Fixes eclipse-basyx#458
Contributor
Author
|
Ironically, the failing pipeline now represents a successful check for the given issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
EXIT_CODEof the copyright year check was hardcoded to the value 0, causing the CI to pass unconditionally.This fixes the bug by coupling the
EXIT_CODEto the result of the copyright year check. Moreover, the check has been extended to additionally verify the copyright year of theLICENSEfile.Fixes #458