Use parser's API support for BigInt#45
Open
haoadoreorange wants to merge 2 commits intoeclipse-cdt-cloud:masterfrom
Open
Use parser's API support for BigInt#45haoadoreorange wants to merge 2 commits intoeclipse-cdt-cloud:masterfrom
haoadoreorange wants to merge 2 commits intoeclipse-cdt-cloud:masterfrom
Conversation
- Use parser's API support instead of normalizing bigint/number ourself. Signed-off-by: Quoc-Hao Tran <quoc-hao.tran@polymtl.ca>
haoadoreorange
force-pushed
the
theia-master
branch
3 times, most recently
from
9c79588 to
9df9898
Compare
Signed-off-by: Quoc-Hao Tran <quoc-hao.tran@polymtl.ca>
haoadoreorange
force-pushed
the
theia-master
branch
from
9df9898 to
9adc68e
Compare
marco-miller
requested changes
Jan 25, 2023
Contributor
marco-miller
left a comment
marco-miller
left a comment
There was a problem hiding this comment.
This aging PR would require a rebase on current latest master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #37, I forked json-bigint and expose the parser's API through a similar mechanism, you can find it here. It now supports a schema-like object wihich allow to do what #37 did during parsing phase.
This PR use that package. It allows to not bothering with type definitions, and also avoid defining
normalizerfor unecessary property.Performance-wise it's theoretically a little bit faster, since we're not re-iterating the object.
Signed-off-by: Quoc-Hao Tran quoc-hao.tran@polymtl.ca