Verify image build functionality using kubedock and podman when spec.devEnvironments.persistUserHome.enabled is set to true#23786
Merged
dmytro-ndp merged 4 commits intoeclipse-che:mainfrom Mar 30, 2026
Conversation
dmytro-ndp
reviewed
Mar 29, 2026
|
|
||
| suiteTeardown(function (): void { | ||
| // restore spec.devEnvironments.persistUserHome.enabled to original value | ||
| shellExecutor.executeCommand( |
Contributor
There was a problem hiding this comment.
The test doesn't fail when oc patch command fails, which leaves patched config the same silently.
Possible fix:
const restoreResult: ShellString = shellExecutor.executeCommand(
`oc patch checluster ${cheClusterName} --type=merge ` +
`-p '{"spec":{"devEnvironments":{"persistUserHome":{"enabled": ${defaultPersistentHomeValue}}}}}'`
);
expect(restoreResult.code).to.equal(0, 'Failed to restore CheCluster persistUserHome setting');
dmytro-ndp
reviewed
Mar 29, 2026
| defaultPersistentHomeValue = currentValue === 'true'; | ||
|
|
||
| // set spec.devEnvironments.persistUserHome.enabled to true | ||
| shellExecutor.executeCommand( |
Contributor
There was a problem hiding this comment.
The test doesn't fail when oc patch command fails silently, making subsequent test failures harder to diagnose.
Possible fix:
const patchResult: ShellString = shellExecutor.executeCommand(
`oc patch checluster ${cheClusterName} --type=merge ` +
'-p \'{"spec":{"devEnvironments":{"persistUserHome":{"enabled": true}}}}\''
);
expect(patchResult.code).to.equal(0, 'Failed to patch CheCluster to enable persistUserHome');
dmytro-ndp
approved these changes
Mar 29, 2026
Contributor
dmytro-ndp
left a comment
There was a problem hiding this comment.
The test looks generally good, but there is still room for improvement.
artaleks9
approved these changes
Mar 30, 2026
dmytro-ndp
approved these changes
Mar 30, 2026
Contributor
dmytro-ndp
left a comment
There was a problem hiding this comment.
@SkorikSergey: thank you for taking review feedback into account.
Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new E2E test to verify image build functionality using kubedock and podman when
spec.devEnvironments.persistUserHome.enabledis set totruein the CheCluster.Test Coverage
The new test (
KubedockPodmanPersistUserHomeTest.spec.ts) covers P03 scenario:persistUserHomein CheCluster before test executionpersistUserHomesetting after test completionChanges
tests/e2e/specs/miscellaneous/KubedockPodmanPersistUserHomeTest.spec.tsTest Plan
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-10596
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.