Add workaround for duplicate workspace warning in CreateWorkspaceWithExistingNameFromEmptyWorkspaceSample e2e test#23788
Draft
SkorikSergey wants to merge 2 commits intoeclipse-che:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a workaround for a known issue where the duplicate workspace warning incorrectly appears when creating an Empty Workspace with "Create New" checkbox OFF.
When creating an Empty Workspace sample with "Create New" checkbox turned OFF, the dashboard shows a duplicate workspace warning even though Empty Workspace should always generate unique names.
Workaround
When the duplicate workspace warning appears unexpectedly, the test now:
Changes
this.skip()with error logging when the warning appearsNote
This workaround should be removed after fixing https://redhat.atlassian.net/browse/CRW-10546
Screenshot/screencast of this PR
What issues does this PR fix or reference?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.