Skip to content

add an editor for p2.inf#2210

Open
nburnwal09 wants to merge 2 commits intoeclipse-pde:masterfrom
nburnwal09:p2inf
Open

add an editor for p2.inf#2210
nburnwal09 wants to merge 2 commits intoeclipse-pde:masterfrom
nburnwal09:p2inf

Conversation

@nburnwal09
Copy link
Copy Markdown

@nburnwal09 nburnwal09 commented Feb 5, 2026

Added an editor for p2.inf in PDE
issue: #1811

p2.inf.editor.mov

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

Test Results

  147 files  ±0    147 suites  ±0   37m 0s ⏱️ + 1m 54s
3 495 tests ±0  3 441 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 306 runs  ±0  9 176 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit ec12364. ± Comparison against base commit 95c57fb.

♻️ This comment has been updated with latest results.

@nburnwal09 nburnwal09 marked this pull request as ready for review February 6, 2026 09:14
@nburnwal09 nburnwal09 force-pushed the p2inf branch 2 times, most recently from f0e6ae5 to 7ed92bb Compare February 6, 2026 10:54
@gireeshpunathil gireeshpunathil changed the title added and editor for p2.inf add an editor for p2.inf Feb 6, 2026
@laeubi laeubi requested review from HannesWell and merks February 9, 2026 09:27
Copy link
Copy Markdown
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks generally okay but I don't have time for a deeper review.

@HannesWell
Copy link
Copy Markdown
Member

I'll try to have a deeper look in the next days.
Thanks for this work.

@nburnwal09
Copy link
Copy Markdown
Author

@laeubi @HannesWell
I have applied the opening of build.properties behaviours to p2.inf in the latest changes.

Also, this PR is for the addition of p2.inf in manifest and feature editor tab just like build.properties.
I will take up the auto-completion and validation part as suggested in the follow up PR once this gets approved.

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

eclipse-pde-bot commented Mar 6, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From ba7e05f4e6f910f115317053ea147e0c0d2c367f Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 13 Mar 2026 07:47:22 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index 87bb6898ee..ddaa9c6ccc 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.400.qualifier
+Bundle-Version: 3.16.500.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@nburnwal09 nburnwal09 force-pushed the p2inf branch 4 times, most recently from bf9b95e to dff1bc5 Compare March 13, 2026 07:44
@nburnwal09
Copy link
Copy Markdown
Author

@HannesWell
Kindly review this PR.
Also the auto-completion for p2.inf editor PR is ready. Once this land, we can proceed with that one.

@nburnwal09
Copy link
Copy Markdown
Author

@HannesWell @merks
If you are ok with this behaviour(shown in the video attached) then I can request @noopur2507 to review and merge this.

@HannesWell Kindly review this PR. Also the auto-completion for p2.inf editor PR is ready. Once this land, we can proceed with that one.

@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 31, 2026

Looks good to me at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants