Add wizard option to enable DS annotation processing#2260
Add wizard option to enable DS annotation processing#2260PrakarshSrivastav wants to merge 2 commits intoeclipse-pde:masterfrom
Conversation
|
Hi @PrakarshSrivastav — thank you for your contribution! The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:
To resolve this, please:
Once done, push a new commit (or rebase) to re-trigger the ECA validation. If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk. Thanks again for your contribution! |
| private boolean fDoGenerateActivator = false; | ||
| private boolean fRCPAppPlugin = false; | ||
| private boolean fSetupAPITooling = false; | ||
| private boolean fEnableDSProcessing = false; |
There was a problem hiding this comment.
Just a nit, and more an observation because and I see the existing fields are initialized with an explicit false. But that's actually pointless because it's the default value, and is actually even a little worse than pointless because it generates pointless byte code that much set the value that is already false to false.
There was a problem hiding this comment.
Got it, do you want me to change it in just my field or in the existing ones as well?
There was a problem hiding this comment.
Not really, there is also value in consistency in the code.
Maybe we eventfully add a cleanup to remove pointless default assignment of null, 0 (including all primitive zero defaults), and false...
Test Results 36 files - 111 36 suites - 111 19s ⏱️ - 34m 31s Results for commit 1f10297. ± Comparison against base commit 2da39b7. This pull request removes 3467 tests. |
Hi, I’m currently trying to complete these steps, but I’m running into an issue during account creation. Every username I try to use while signing up including a randomly generated UUID results in the error shown below. Please advise on what to do. Thanks!
|
|
sorry for the inconvenience with creating an Eclipse account. we had an outage due to a buggy update, but it should be resolved now, please retry. |
|
Hello, |


Fixes #2259