Skip to content

Add wizard option to enable DS annotation processing#2260

Open
PrakarshSrivastav wants to merge 2 commits intoeclipse-pde:masterfrom
PrakarshSrivastav:topic/ds-processing-option
Open

Add wizard option to enable DS annotation processing#2260
PrakarshSrivastav wants to merge 2 commits intoeclipse-pde:masterfrom
PrakarshSrivastav:topic/ds-processing-option

Conversation

@PrakarshSrivastav
Copy link
Copy Markdown

@PrakarshSrivastav PrakarshSrivastav commented Mar 16, 2026

Fixes #2259

@eclipse-eca-validation
Copy link
Copy Markdown

Hi @PrakarshSrivastav — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

  • Committing user must have an Eclipse Account
  • Author must have an Eclipse Account

To resolve this, please:

  1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
  2. Ensure your GitHub username is linked to your Eclipse account
  3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

private boolean fDoGenerateActivator = false;
private boolean fRCPAppPlugin = false;
private boolean fSetupAPITooling = false;
private boolean fEnableDSProcessing = false;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, and more an observation because and I see the existing fields are initialized with an explicit false. But that's actually pointless because it's the default value, and is actually even a little worse than pointless because it generates pointless byte code that much set the value that is already false to false.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, do you want me to change it in just my field or in the existing ones as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, there is also value in consistency in the code.

@laeubi

Maybe we eventfully add a cleanup to remove pointless default assignment of null, 0 (including all primitive zero defaults), and false...

@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 16, 2026

@PrakarshSrivastav

If your commit message included URL for the issue, then the PR would be automatically linked to that issue. You can even specify that the issue be closed when the PR is merged:

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Is your PR based on the current master? I think not because I see this is enabled:

image

@github-actions
Copy link
Copy Markdown

Test Results

 36 files   -   111   36 suites   - 111   19s ⏱️ - 34m 31s
 26 tests  - 3 467   26 ✅  - 3 409  0 💤  -  54  0 ❌  - 4 
135 runs   - 9 168  135 ✅  - 9 034  0 💤  - 130  0 ❌  - 4 

Results for commit 1f10297. ± Comparison against base commit 2da39b7.

This pull request removes 3467 tests.
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractCommandWithCategory
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractHandlerWithoutCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractPlaceHolder
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandledItemsWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractResolveCommandsWithTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractSinglePart
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithDifferentCommands
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoHandlerWithSameCommand
org.eclipse.e4.tools.test.FragmentExtractHelperTest ‑ testExtractTwoPartsSameLocation
…

@PrakarshSrivastav
Copy link
Copy Markdown
Author

PrakarshSrivastav commented Mar 16, 2026

Hi @PrakarshSrivastav — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

  • Committing user must have an Eclipse Account
  • Author must have an Eclipse Account

To resolve this, please:

  1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
  2. Ensure your GitHub username is linked to your Eclipse account
  3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

Hi, I’m currently trying to complete these steps, but I’m running into an issue during account creation.

Every username I try to use while signing up including a randomly generated UUID results in the error shown below.

Please advise on what to do. Thanks!

image

@netomi
Copy link
Copy Markdown

netomi commented Mar 17, 2026

sorry for the inconvenience with creating an Eclipse account.

we had an outage due to a buggy update, but it should be resolved now, please retry.

@PrakarshSrivastav
Copy link
Copy Markdown
Author

Hello,
I pushed a merge commit, and now the ECA check is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The project wizard should have an option to enable the DS annotation processing

3 participants