Replace StringBuffer with StringBuilder in ClasspathComputer3_0#2273
Open
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Open
Replace StringBuffer with StringBuilder in ClasspathComputer3_0#2273laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
Test Results 147 files ±0 147 suites ±0 36m 25s ⏱️ +2s For more details on these failures, see this check. Results for commit 906f333. ± Comparison against base commit 88552db. ♻️ This comment has been updated with latest results. |
The local variable `buffer` is not shared across threads, so StringBuilder is the appropriate choice and avoids unnecessary synchronization overhead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
laeubi
force-pushed
the
fix/stringbuffer-to-stringbuilder-classpathcomputer
branch
from
ac353a8 to
906f333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the synchronized
StringBufferwithStringBuilderinClasspathComputer3_0.The local variable
bufferis not shared across threads, soStringBuilderis the appropriate choice and avoids unnecessary synchronization overhead.