Skip to content

Migration of https://wiki.eclipse.org/PDE/UI/SourceReferences#2285

Merged
vogella merged 1 commit intoeclipse-pde:masterfrom
vogella:wiki-source-migration
Apr 7, 2026
Merged

Migration of https://wiki.eclipse.org/PDE/UI/SourceReferences#2285
vogella merged 1 commit intoeclipse-pde:masterfrom
vogella:wiki-source-migration

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 7, 2026

Additional changes:

  • Standardized headings to ATX style (#, ##, ###).
  • Converted indented code blocks and inline code with complex content to
    triple-backtick fenced code blocks with language hints (xml, properties,
    text).
  • Fixed a broken/messy inline link within the Eclipse-SourceReferences
    example.
  • Removed unnecessary backslash escaping in XML comments.
  • Removed the manual Table of Contents as it is synthesized by the website.
  • Reformatted paragraphs to start each sentence on a new line for easier
    future editing.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Test Results

  147 files  ±0    147 suites  ±0   36m 5s ⏱️ -10s
3 497 tests ±0  3 443 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 312 runs  ±0  9 182 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 254e8df. ± Comparison against base commit 1aece37.

♻️ This comment has been updated with latest results.

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 7, 2026

Given both the GitHub page and the website markdown renderer synthesize a table of contents, wouldn’t it be better to omit it?

For future editing it would be better if a paragraph were not one huge long line. Better would be each sentence start on a new line.

@vogella vogella force-pushed the wiki-source-migration branch from 42d2f7a to 254e8df Compare April 7, 2026 08:03
@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 7, 2026

Thank you. That’s much nicer!

Copy link
Copy Markdown
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image files are actually text files that show 404 not found

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 7, 2026

I thought it was just my bad internet on my phone.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 7, 2026

Looks like I did not update the image URl in my script... Update will be posted soon

@vogella vogella force-pushed the wiki-source-migration branch from 254e8df to a77c21a Compare April 7, 2026 09:27
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 7, 2026

URLs like https://raw.githubusercontent.com/eclipse-pde/eclipse.pde/master/docs/images/Repo-import-1.png will currently still go 404 as the images has not yet been committed.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Apr 7, 2026

URLs like https://raw.githubusercontent.com/eclipse-pde/eclipse.pde/master/docs/images/Repo-import-1.png will currently still go 404 as the images has not yet been committed.

Why not using a relative URL so one can review the results right in this PR?

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 7, 2026

URLs like https://raw.githubusercontent.com/eclipse-pde/eclipse.pde/master/docs/images/Repo-import-1.png will currently still go 404 as the images has not yet been committed.

Why not using a relative URL so one can review the results right in this PR?

IIRC this did not work with raw display.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Apr 7, 2026

URLs like https://raw.githubusercontent.com/eclipse-pde/eclipse.pde/master/docs/images/Repo-import-1.png will currently still go 404 as the images has not yet been committed.

Why not using a relative URL so one can review the results right in this PR?

IIRC this did not work with raw display.

I'm not sure what we are talking about here? Github markdown does not need any "raw" links... see for example https://github.com/eclipse-m2e/m2e-core/blob/main/README.md that has ![M2E-Banner](assets/m2e-Banner.svg) as a reference to an image inside the repo.

Also the images itself still seem broken, looking at https://github.com/vogella/eclipse.pde/blob/a77c21af15818bf5fff7ec5550747d64bac3fa51/docs/images/Repo-import-1.png it still shows me a textfile that contains the text "Not found".

grafik

Also github complains:

grafik

Additional changes:

- Standardized headings to ATX style (#, ##, ###).
- Converted indented code blocks and inline code with complex content to
triple-backtick fenced code blocks with language hints (xml, properties,
text).
- Fixed a broken/messy inline link within the Eclipse-SourceReferences
example.
- Removed unnecessary backslash escaping in XML comments.
- Updated the manual Table of Contents to match the generated anchor IDs
for the new headings.
@vogella vogella force-pushed the wiki-source-migration branch from a77c21a to 377dd09 Compare April 7, 2026 09:36
@vogella vogella merged commit 23e81c6 into eclipse-pde:master Apr 7, 2026
5 of 7 checks passed
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 7, 2026

https://github.com/eclipse-pde/eclipse.pde/blob/master/docs/SourceReferences.md renders fine, please feel free to continue improving the page.

@HannesWell
Copy link
Copy Markdown
Member

Thank you Lars for the immediate addition.
I've already incorporated it into

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 8, 2026

When you force pushed the last change it appears that you undid the changes to remove the TOC and went back to long one-line paragraphs.

merks added a commit to merks/eclipse.pde that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants