Introduce simple API to save ImageData to file and support '.jpg' extension#2103
Introduce simple API to save ImageData to file and support '.jpg' extension#2103HannesWell wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
3627584 to
19b2b72
Compare
laeubi
left a comment
There was a problem hiding this comment.
I don't think we should clutter the ImageData class more can't we use ImageLoader(sic) for this that already is used internally anyways?
|
Currently there are only convenience methods to load That one has to write an article about how to simply write an image to a file, is IMO an indication that the API is too complicated: Of course there are cases where one still needs an |
|
I don't think that adding methods to So why cant this static methods live in |
|
Would you please split the *.jpg support in its own PR so it can be merged now? |
Currently it's quite cumbersome to save ImageData into a file. screenshot from a
Controlor aDisplay. This proposes a convenience API to simplify this task.This also complements the ImageData.load(Path) method introduced in
It becomes also very simple to take and save a screenshot together with