Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Jan 29, 2026

Changed Control.adjustWindowRectEx to use getShellZoom() instead of shell.getZoom(). This ensures consistency with nativeZoom which is used by computeTrim and other layout logic, preventing the possibility of incorrect
border sizing when shell.getZoom() and nativeZoom are out of sync

Changed Control.adjustWindowRectEx to use getShellZoom() instead of
shell.getZoom(). This ensures consistency with nativeZoom which is
used by computeTrim and other layout logic, preventing the possibility
of incorrect
border sizing when shell.getZoom() and nativeZoom are out of sync
@github-actions
Copy link
Contributor

Test Results (win32)

   34 files  ±0     34 suites  ±0   4m 50s ⏱️ -8s
4 640 tests ±0  4 567 ✅ ±0  73 💤 ±0  0 ❌ ±0 
  170 runs  ±0    167 ✅ ±0   3 💤 ±0  0 ❌ ±0 

Results for commit cab3be8. ± Comparison against base commit 9a2a885.

@HeikoKlare
Copy link
Contributor

shell.getZoom() and nativeZoom are out of sync

This should only be the case if you have disabled autoscaling for a control. And in that case it's necessary to take the proper shell zoom for those metrics as otherwise scaling will be wrong. So from my understanding, the current implementation is correct as is.

Can you give an example where the current implementation does not behave as expected?

@vogella
Copy link
Contributor Author

vogella commented Jan 29, 2026

shell.getZoom() and nativeZoom are out of sync

This should only be the case if you have disabled autoscaling for a control. And in that case it's necessary to take the proper shell zoom for those metrics as otherwise scaling will be wrong. So from my understanding, the current implementation is correct as is.

Can you give an example where the current implementation does not behave as expected?

#3020 might be related.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, I don't see that this can make anything better but will just break autoscale disablement at the widget level. Without any reproduce of an issue that this solves and the fact it will actually break behavior, this cannot be merged.

@vogella
Copy link
Contributor Author

vogella commented Jan 29, 2026

LTM that the other widgets are using the same approach hence this proposed change.

image

shell.getZoom() is only used in one place

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants