Skip to content

Migrate 4 effects to Graphics Example: Dancing, BumpMapping, FlatText, Lens#3223

Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella:feature/migrate-5-oldschool-effects
Open

Migrate 4 effects to Graphics Example: Dancing, BumpMapping, FlatText, Lens#3223
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella:feature/migrate-5-oldschool-effects

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 11, 2026

Summary

Migrate the next 4 old-school effects from SWT-OldSchoolEffect to the GraphicsExample framework.

Effects migrated:

  • DancingTab — Isometric dancing shape with sine-wave grid deformations (Phase 1: pure algorithmic)
  • BumpMappingTab — Bump mapping with moving light source (Phase 2: uses bump.png)
  • FlatTextTab — Flat text perspective distortion (Phase 2: uses TEXFLAT2.png)
  • LensTab — Spherical lens distortion bouncing across image (Phase 2: uses tuxblackbg.png)

Checklist (per #3189):

  • No Color disposal (Colors are not disposed in modern SWT)
  • Use simple new Color(r, g, b) constructor
  • Dispose Images (in dispose() override or before recreation)
  • Dispose GC after use
  • No compiler errors or warnings
  • Use $NON-NLS-1$ markers for string literals
  • Proper EPL-2.0 copyright header with original author credit
  • Category = "Misc"
  • Localized strings via examples_graphics.properties
  • Inner classes for helpers (PointIso inlined as arrays in DancingTab)
  • Build verified: mvn clean verify -Dnative=gtk.linux.x86_64 -DskipTests succeeds

Closes partially #3189

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2026

Test Results

  170 files  ±0    170 suites  ±0   26m 25s ⏱️ +33s
4 692 tests ±0  4 671 ✅ ±0   21 💤 ±0  0 ❌ ±0 
6 670 runs  ±0  6 515 ✅ ±0  155 💤 ±0  0 ❌ ±0 

Results for commit aeac326. ± Comparison against base commit 188aed6.

♻️ This comment has been updated with latest results.

@vogella vogella marked this pull request as ready for review April 11, 2026 09:30
…, Lens

Migrate the next 4 old-school effects from SWT-OldSchoolEffect to the
GraphicsExample framework:

- DancingTab: Isometric dancing shape with sine-wave grid deformations
- BumpMappingTab: Bump mapping with moving light source (uses bump.png)
- FlatTextTab: Flat text perspective distortion (uses TEXFLAT2.png)
- LensTab: Spherical lens distortion bouncing across image (uses tuxblackbg.png)

Each effect extends AnimatedGraphicsTab with proper resource disposal,
localized strings in examples_graphics.properties, and registration in
GraphicsExample.createTabs().

See eclipse-platform#3189

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vogella vogella changed the title Migrate 5 effects to Graphics Example: Dancing, BumpMapping, FlatText, Lake, Lens Migrate 4 effects to Graphics Example: Dancing, BumpMapping, FlatText, Lens Apr 12, 2026
@vogella vogella force-pushed the feature/migrate-5-oldschool-effects branch from 593de9b to aeac326 Compare April 12, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant