Prompt user when switching to a locked workspace in Eclipse#3518
Prompt user when switching to a locked workspace in Eclipse#3518SougandhS wants to merge 3 commits intoeclipse-platform:masterfrom
Conversation
Test Results 3 018 files ±0 3 018 suites ±0 2h 12m 57s ⏱️ - 9m 58s For more details on these failures, see this check. Results for commit 41c3dfe. ± Comparison against base commit e15e9bf. ♻️ This comment has been updated with latest results. |
|
Hi @iloveeclipse, could you please check this PR when you get some time ? |
iloveeclipse
left a comment
There was a problem hiding this comment.
I can check on Monday. The idea itself is good.
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
243aaf8 to
279a4ef
Compare
|
would it be possible to bring up the exact same dialog (with the same information) in both situations? |
Sure 👍 |
279a4ef to
954cc49
Compare
Updated as suggested My.Movie.mp4 |
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
b3e89f9 to
a7c8013
Compare
e2ca711 to
fc83bc2
Compare
|
@iloveeclipse Could u please re-check this ? |
iloveeclipse
left a comment
There was a problem hiding this comment.
I believe M3 is the bad time for changing workspace locking code. Take time, test the change also please with the workspace selection dialog that is shown on Eclipse startup, and if everything will work, it could land in the next release.
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
fc83bc2 to
54146c5
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
ed5958e to
51a81db
Compare
Prompts user on attempting to switch to a workspace that is currently locked by another Eclipse instance, a prompt dialog is now shown informing the user about the lock details and preventing Eclipse from exiting sdsd
51a81db to
41c3dfe
Compare


This change prompts the user when attempting to switch to a workspace in Eclipse that is currently locked by another instance, preventing Eclipse from restarting into the locked workspace. Previously, if Eclipse restarted with a locked workspace, the workspace lock prompt would appear, and clicking “OK” would exit the application, requiring the user to reopen Eclipse to select an active workspace. With this update, the user is warned before switching, informed about the lock via a dialog, and prevented from restarting into the locked workspace, improving workflow and avoiding unnecessary restarts.
Before :
before.mp4
After :
(commented out the initial development mode check for this video)
after.mp4