In Project Explorer, ensure "Select All" (Ctrl+A and menu) works reliably irrespective of first or subsequent selections. by deepika-u · Pull Request #3534 · eclipse-platform/eclipse.platform.ui

deepika-u · 2025-11-11T17:31:13Z

Description:
In the Project Explorer, the "Edit > Select All" menu item and Ctrl+A shortcut did not work reliably when a single project was selected. Specifically, pressing Ctrl+A after selecting a project for the first time had no effect. Only after clicking another project did Ctrl+A begin to work as expected.

Details of the fix:

Added a KeyListener to the Tree widget to handle Ctrl+A directly, ensuring selection works even without command activation.
Registered a IPartListener2 to activate the EDIT_SELECT_ALL command handler when the Project Explorer view becomes active, enabling the menu item.
Deactivated the handler when the view is no longer active to avoid stale references.

Note : No-ops - These methods are required by the IPartListener2 interface though unused but must be implemented. Yeah - i just tried even if removed it works(not sure if it added some warnings).

Open eclipse freshly, open Project Explorer view. Select a project and ctrl+A to select all the projects.
Before fix(unable to select, next click on 2nd project then ctrl+A will be enabled)

After fix(able to select)

github-actions · 2025-11-11T18:18:55Z

Test Results

3 024 files ±0 3 024 suites ±0 2h 15m 50s ⏱️ - 6m 46s
8 232 tests ±0 7 981 ✅ - 3 248 💤 ±0 3 ❌ +3
23 520 runs ±0 22 724 ✅ - 5 791 💤 ±0 5 ❌ +5

For more details on these failures, see this check.

Results for commit 7bd7d58. ± Comparison against base commit b44e9ab.

♻️ This comment has been updated with latest results.

merks · 2025-11-12T11:25:40Z

bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigator.java

+			}
+
+			// no-ops for the other methods:
+			@Override


All the methods have default implementations so these stubs are just useless noise.

As suggested, removed them.

merks · 2025-11-12T11:28:26Z

bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigator.java

+		// Immediate fallback: handle Ctrl+A at the Tree level
+		commonViewer.getTree().addKeyListener(new KeyAdapter() {
+			@Override
+			public void keyPressed(KeyEvent e) {


Somehow it seems like a hack to handle this one key directly, especially given the key binding appears to be configurable:

Note, CommonViewer is a base class in CNF and can be extended. Adding key and part listeners that consumes key or register handlers here directly might affect others code. So please carefully change the code here, it is not only about Project Explorer.

Somehow it seems like a hack to handle this one key directly, especially given the key binding appears to be configurable:

Let me check on it.

eclipse-platform-bot · 2025-12-02T11:27:30Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 00affcbceaaa0f1547e02667148b1a209e31433a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Tue, 2 Dec 2025 11:27:07 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.ui.navigator/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator/META-INF/MANIFEST.MF
index e2e4391692..3a92eee523 100644
--- a/bundles/org.eclipse.ui.navigator/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator; singleton:=true
-Bundle-Version: 3.13.300.qualifier
+Bundle-Version: 3.13.400.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.NavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

merks · 2026-01-12T09:49:11Z

bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonNavigator.java

+			@Override
+			public void keyPressed(KeyEvent e) {
+				// MOD1 = Ctrl on Win/Linux, Command on macOS
+				if ((e.stateMask & SWT.MOD1) != 0 && (e.keyCode == 'a' || e.keyCode == 'A')) {


This continues to hard code a key binding that is configurable doesn't it?

merks

It continues to feel like we are treating a symptom and not fixing an underlying problem.

deepika-u · 2026-01-12T10:10:02Z

@merks
Sorry for the delayed reply on your comments.
I have revised the fix as per your suggestion. When you get some time, can you take a look at this please?
Thanks alot.

reliably irrespective of first or subsequent selections.

deepika-u force-pushed the 2739_edit_selectall branch from a63f01a to 98792b8 Compare November 11, 2025 17:32

merks requested changes Nov 12, 2025

View reviewed changes

deepika-u force-pushed the 2739_edit_selectall branch 2 times, most recently from a3fe77d to a49db52 Compare November 12, 2025 14:11

deepika-u force-pushed the 2739_edit_selectall branch from a49db52 to 835fc39 Compare December 2, 2025 11:21

deepika-u force-pushed the 2739_edit_selectall branch 2 times, most recently from 8849f93 to a9f91c5 Compare January 9, 2026 11:58

vogella requested a review from merks January 12, 2026 09:40

merks reviewed Jan 12, 2026

View reviewed changes

deepika-u force-pushed the 2739_edit_selectall branch 3 times, most recently from 08db76d to 876fada Compare January 12, 2026 10:08

deepika-u force-pushed the 2739_edit_selectall branch 2 times, most recently from 124b217 to dd70538 Compare January 13, 2026 07:03

deepika-u force-pushed the 2739_edit_selectall branch 2 times, most recently from 41c3a5c to 77edf2b Compare February 3, 2026 11:28

deepika-u added 2 commits February 4, 2026 11:49

In Project Explorer, ensure "Select All" (Ctrl+A and menu) works

fe90830

reliably irrespective of first or subsequent selections.

Revised the fix as per the suggestion.

7bd7d58

vogella force-pushed the 2739_edit_selectall branch from 77edf2b to 7bd7d58 Compare February 4, 2026 10:49

vogella requested a review from merks February 4, 2026 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In Project Explorer, ensure "Select All" (Ctrl+A and menu) works reliably irrespective of first or subsequent selections.#3534

In Project Explorer, ensure "Select All" (Ctrl+A and menu) works reliably irrespective of first or subsequent selections.#3534
deepika-u wants to merge 2 commits intoeclipse-platform:masterfrom
deepika-u:2739_edit_selectall

deepika-u commented Nov 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

merks Nov 12, 2025

Uh oh!

deepika-u Nov 12, 2025

Uh oh!

merks Nov 12, 2025

Uh oh!

iloveeclipse Nov 12, 2025

Uh oh!

deepika-u Nov 12, 2025

Uh oh!

eclipse-platform-bot commented Dec 2, 2025

Uh oh!

merks Jan 12, 2026

Uh oh!

merks left a comment

Uh oh!

deepika-u commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

deepika-u commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

merks Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

deepika-u Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

merks Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

iloveeclipse Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

deepika-u Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

eclipse-platform-bot commented Dec 2, 2025

Uh oh!

merks Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

merks left a comment

Choose a reason for hiding this comment

Uh oh!

deepika-u commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deepika-u commented Nov 11, 2025 •

edited

Loading

github-actions bot commented Nov 11, 2025 •

edited

Loading