Fix race condition in FilteredItemsSelectionDialog initial selection

[vogella]

The flaky ResourceInitialSelectionTest failures were caused by a race condition in FilteredItemsSelectionDialog.refresh() where setSelection() was called immediately after tableViewer.refresh(), before the table had fully updated its items.

Root cause:

• FilteredItemsSelectionDialog.refresh() calls tableViewer.refresh() (line 874)
• This triggers async table updates, especially for virtual tables
• setSelection() was called immediately after (line 883), assuming refresh was complete
• On slow systems, the selection would be applied to an incomplete table
  and silently fail, resulting in empty selection: expected:<[...foo.txt]>
  but was:<[]>

The issue manifested as flaky test failures:

• testMultiSelectionAndSomeInitialNonExistingSelectionWithInitialPattern
• testSingleSelectionAndOneInitialSelectionWithInitialPattern
• testMultiSelectionAndTwoInitialSelectionsWithInitialPattern

These tests would intermittently fail with "Two files should be selected by default" or "One file should be selected by default" assertions.

Solution:
Wrapped both selection application paths in Display.asyncExec() to defer selection until after the table refresh completes:

1. For preserving previous selection:

   • Changed from: tableViewer.setSelection(new StructuredSelection(...))
   • Changed to: Display.asyncExec(() -> tableViewer.setSelection(...))

2. For default first item selection:

   • Changed from: table.setSelection(0)
   • Changed to: Display.asyncExec(() -> table.setSelection(0))

Both paths now include disposal checks to prevent errors if the dialog is closed before the async execution runs.

The test's existing waitForDialogRefresh() method processes these async events through its processUIEvents() calls, ensuring selections are applied before assertions run. Updated the comment to reflect the asyncExec fix.

Verified with multiple consecutive test runs - all 13 tests pass consistently.

Fixes: #294

🤖 Generated with Claude Code

[github-actions]

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 24m 44s ⏱️ +29s
 8 270 tests ±0   8 019 ✅  - 3  248 💤 ±0  3 ❌ +3 
23 634 runs  ±0  22 839 ✅  - 4  791 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit ef70385. ± Comparison against base commit 799f52a.

♻️ This comment has been updated with latest results.