Add font zoom functionality to console view by raghucssit · Pull Request #2579 · eclipse-platform/eclipse.platform

raghucssit · 2026-03-18T21:40:39Z

-Add key listener on text widget of console view which listens ctrl plus and control minus(including numpad +/-)
-Zoom in/out of the console view text in steps based on the keys pressed.

see #2578

Copilot

Pull request overview

Adds Ctrl +/- (including numpad +/-) zoom support to the Eclipse Console view to align behavior with text editors (Issue #2578).

Changes:

Installs a key listener on the console’s StyledText to detect Ctrl+Plus / Ctrl+Minus.
Implements font resizing logic with min/max bounds and a step size, creating a derived SWT Font.
Disposes the created font on view disposal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java

github-actions · 2026-03-18T22:14:23Z

Test Results

54 files ±0 54 suites ±0 36m 39s ⏱️ + 1m 10s
4 556 tests ±0 4 533 ✅ ±0 23 💤 ±0 0 ❌ ±0
12 264 runs ±0 12 105 ✅ ±0 159 💤 ±0 0 ❌ ±0

Results for commit e1d88b4. ± Comparison against base commit 3f8585f.

♻️ This comment has been updated with latest results.

iloveeclipse · 2026-03-19T16:12:22Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java


+		// Install font zoom key listener on the StyledText widget
+		StyledText textWidget = null;
+		if (page instanceof TextConsolePage textPage) {


I did not do full review, but looking at this palce here wonder if the code change should be done in TextConsolePage and all init in createControl() there? Because all other pages are irrelevant for the new code.

iloveeclipse · 2026-03-19T16:19:18Z

Have you thought about persisting the current zoom over the current session? That will be likely next immediate customer request after using this feature for the first time & IDE restart.

Assuming the code moved to the page (from the console), we would always know "where we are" and should be able to persist the zoom in the preference store by using the IConsole.getType() as part of the key.

raghucssit · 2026-03-24T09:33:09Z

@trancexpress Please check this PR.

trancexpress · 2026-03-24T11:10:06Z

With:

Eclipse SDK
Version: 2026-06 (4.40)
Build id: I20260323-1800

The Console view can be zoomed when I'm in the Java editor and I press: Ctrl and =

The change here makes me press Ctrl+ though, i.e. Ctrl and Shift and =. That seems odd. For Ctrl - its the same.

The Java editor zoom in / zoom out resets whatever the zoom level was in the console, which is probably OK.

trancexpress · 2026-03-24T11:12:42Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/TextConsolePage.java

+	 * @param delta the amount to change the font size (positive to increase,
+	 *              negative to decrease)
+	 */
+	private void changeFontSize(int delta) {


It seems odd that I can do this from the Java editor without this code. Can you check if some existing code can be re-used here?

Copilot

Pull request overview

Adds Ctrl +/- key handling to the Console view’s text widget to support zooming the console font size, addressing the usability gap described in #2578.

Changes:

Add a key listener on the console StyledText to zoom font size on Ctrl + / Ctrl - (including numpad +/-).
Implement per-console-type font persistence via the console plug-in preference store and restore it on page creation.
Minor whitespace adjustment in ConsoleView.dispose().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java	Minor formatting-only change in `dispose()`.
debug/org.eclipse.ui.console/src/org/eclipse/ui/console/TextConsolePage.java	Adds zoom key listener, font resizing logic, and preference-based font load/save for console pages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/TextConsolePage.java

-Add key listener on text widget of console view which listens ctrl plus and control minus(including numpad +/-) -Zoom in/out of the console view text in steps based on the keys pressed. see eclipse-platform#2578

raghucssit · 2026-04-09T07:58:51Z

@iloveeclipse Please check this PR.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T08:27:43Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/ConsoleZoomInHandler.java

+		Display display = Display.getCurrent();
+		if (display == null) {
+			display = Display.getDefault();
+		}
+		Display d = display;
+		d.asyncExec(() -> {


execute() for command handlers is normally invoked on the UI thread. Using Display#asyncExec here makes the operation race with focus changes (the focused control may no longer be the console StyledText when the runnable runs), causing zoom to apply to the wrong control or do nothing. Prefer running the logic immediately when Display.getCurrent() is non-null, and only fall back to syncExec when invoked off the UI thread; also capture getFocusControl() once instead of calling it multiple times.

Copilot · 2026-04-09T08:27:44Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/ConsoleZoomInHandler.java

+package org.eclipse.ui.console;
+
+import org.eclipse.core.commands.AbstractHandler;


These handler implementation classes are in the exported API package org.eclipse.ui.console and are public, which effectively commits them as API. Since handlers are internal implementation details, consider moving them to an internal package (e.g., org.eclipse.ui.internal.console) and updating plugin.xml accordingly to avoid unintended API surface.

Copilot · 2026-04-09T08:27:44Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/ConsoleZoomInHandler.java

+	@Override
+	public Object execute(ExecutionEvent event) throws ExecutionException {
+		changeFocusedFont(STEP);
+		return null;
+	}
+
+	private void changeFocusedFont(int delta) {


ConsoleZoomInHandler and ConsoleZoomOutHandler are nearly identical (only the delta differs). This duplication increases the chance of the two drifting over time. Consider extracting the shared logic into a common utility/base class, or using a single parameterized handler (e.g., via a command parameter for the delta).

Copilot · 2026-04-09T08:27:44Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/ConsoleZoomOutHandler.java

+		Display display = Display.getCurrent();
+		if (display == null) {
+			display = Display.getDefault();
+		}
+		Display d = display;
+		d.asyncExec(() -> {
+			StyledText st = d.getFocusControl() instanceof StyledText ? (StyledText) d.getFocusControl() : null;


Same asyncExec focus-race issue as in ConsoleZoomInHandler: scheduling asynchronously can run after focus has changed, so zoom-out may target the wrong control. Prefer executing immediately on the UI thread (or syncExec when needed) and capture the focus control once.

Copilot · 2026-04-09T08:27:44Z

debug/org.eclipse.ui.console/src/org/eclipse/ui/console/ConsoleZoomOutHandler.java

+package org.eclipse.ui.console;
+
+import org.eclipse.core.commands.AbstractHandler;


This handler implementation is in the exported API package org.eclipse.ui.console and is public, which unintentionally adds API surface. Consider moving it to an internal package and updating the handler declaration in plugin.xml.

Copilot · 2026-04-09T08:27:45Z

debug/org.eclipse.ui.console/plugin.xml

+           sequence="M1+Plus">
+     </key>
+     <key
+           commandId="org.eclipse.ui.console.command.fontZoomIn"
+           contextId="org.eclipse.ui.console.ConsoleView"
+           schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"


The key sequence token Plus is not used anywhere else in this repository’s key bindings, and M1+= already covers the common Ctrl+'+' (shift+'=') case while M1+NUMPAD_ADD covers the keypad. If Plus is not a recognized key name, this binding will be ignored at runtime. Consider removing this binding or replacing it with a verified/standard key token.

Suggested change

sequence="M1+Plus">

</key>

<key

commandId="org.eclipse.ui.console.command.fontZoomIn"

contextId="org.eclipse.ui.console.ConsoleView"

schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"

Copilot · 2026-04-09T08:27:45Z

debug/org.eclipse.ui.console/plugin.xml

+            categoryId="AnsiConsole.command.categoryid">
+      </command>
+      <command
+            id="org.eclipse.ui.console.command.fontZoomOut"
+            name="%command.console.fontZoomOut.name"
+            description="%command.console.fontZoomOut.description"
+            categoryId="AnsiConsole.command.categoryid">


These new zoom commands are categorized under AnsiConsole.command.categoryid ("ANSI Support Commands"), but zooming the console font is not ANSI-specific. This will make the commands appear under an incorrect/misleading category in the Keys preference page. Consider using a more appropriate category (e.g., org.eclipse.ui.category.edit) or introducing a dedicated Console category.

Suggested change

categoryId="AnsiConsole.command.categoryid">

</command>

<command

id="org.eclipse.ui.console.command.fontZoomOut"

name="%command.console.fontZoomOut.name"

description="%command.console.fontZoomOut.description"

categoryId="AnsiConsole.command.categoryid">

categoryId="org.eclipse.ui.category.edit">

</command>

<command

id="org.eclipse.ui.console.command.fontZoomOut"

name="%command.console.fontZoomOut.name"

description="%command.console.fontZoomOut.description"

categoryId="org.eclipse.ui.category.edit">

Copilot AI review requested due to automatic review settings March 18, 2026 21:40

Copilot AI reviewed Mar 18, 2026

View reviewed changes

debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java Outdated Show resolved Hide resolved

raghucssit force-pushed the console_zoom_support branch from 74720eb to 21d419f Compare March 19, 2026 15:57

iloveeclipse reviewed Mar 19, 2026

View reviewed changes

raghucssit force-pushed the console_zoom_support branch from 21d419f to c051ad1 Compare March 24, 2026 08:49

trancexpress reviewed Mar 24, 2026

View reviewed changes

iloveeclipse requested a review from Copilot March 24, 2026 16:08

Copilot started reviewing on behalf of iloveeclipse March 24, 2026 16:08 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

raghucssit force-pushed the console_zoom_support branch 2 times, most recently from cb6dbf0 to 0c77159 Compare March 25, 2026 16:04

raghucssit force-pushed the console_zoom_support branch 2 times, most recently from d794c2b to 9dd0a16 Compare April 7, 2026 23:48

Add font zoom functionality to console view

e1d88b4

-Add key listener on text widget of console view which listens ctrl plus and control minus(including numpad +/-) -Zoom in/out of the console view text in steps based on the keys pressed. see eclipse-platform#2578

raghucssit force-pushed the console_zoom_support branch from 9dd0a16 to e1d88b4 Compare April 7, 2026 23:51

iloveeclipse requested a review from Copilot April 9, 2026 08:21

Copilot started reviewing on behalf of iloveeclipse April 9, 2026 08:21 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

		package org.eclipse.ui.console;

		import org.eclipse.core.commands.AbstractHandler;

Conversation

raghucssit commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

iloveeclipse Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

iloveeclipse commented Mar 19, 2026

Uh oh!

raghucssit commented Mar 24, 2026

Uh oh!

trancexpress commented Mar 24, 2026

Uh oh!

trancexpress Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

raghucssit commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 18, 2026 •

edited

Loading