Add N&N - quick fix for addition of available matching version#517
Add N&N - quick fix for addition of available matching version#517nburnwal09 wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
|
@merks |
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Great feature. Just some minor tweaks.
I did wonder what range is generated. For example, if the actual version is 1.2.300, does it produce [1.2.0,2.0.0)? You might consider to describe that.
news/4.40/pde.md
Outdated
|  | ||
|
|
||
| The quick fix is labeled as `Require latest available version range`. | ||
| Once the user clicks on `Finish`, it adds the version to the specific Require bundle or Import package. |
There was a problem hiding this comment.
Require and Import should not be capitalized.
news/4.40/pde.md
Outdated
|  | ||
|
|
||
|
|
||
| ### Version Mapping for Required Bundles and Imported packages |
There was a problem hiding this comment.
packages should be upper case.
news/4.40/pde.md
Outdated
|
|
||
| The quick fix is labeled as `Require latest available version range`. | ||
| Once the user clicks on `Finish`, it adds the version to the specific Require bundle or Import package. | ||
| This quick fix is added to enhance user experience. No newline at end of file |
There was a problem hiding this comment.
I would just leave this out. It goes without saying. 😀
Thank you
Yeah you are right. |
nburnwal09
force-pushed
the
quickFix_addVersionRange
branch
from
7e3563a to
ebcd6d6
Compare
nburnwal09
changed the title
I think it’s useful information for the user. A simple sentence with an example would make the entry more informative and richer. |
|  | ||
|
|
||
| The quick fix is labeled as `Require latest available version range`. | ||
| Once the user clicks on `Finish`, it adds the version to the specific require bundle or import package. No newline at end of file |
There was a problem hiding this comment.
It actually adds a version range, and here would be a good place for a “for example”.
2 participants
Enhancement in pde quick fixes: eclipse-pde/eclipse.pde#1791
eclipse-pde/eclipse.pde#1962