Add Pawel to IT team acknowledgements#522
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Eclipse release-note acknowledgement templates and the 4.40 acknowledgements to recognize an additional Eclipse Foundation staff member.
Changes:
- Add Paweł Stankiewicz to the Eclipse Foundation staff acknowledgements in the 4.40 release notes.
- Add the same acknowledgement to the
4.xtemplate so future release notes include it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| news/4.x-template/acknowledgements.md | Adds Paweł Stankiewicz to the Eclipse Foundation staff thank-you line in the template. |
| news/4.40/acknowledgements.md | Adds Paweł Stankiewicz to the Eclipse Foundation staff thank-you line for the 4.40 release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| The entire Eclipse Project team would like to thank the [Eclipse Foundation staff](https://www.eclipse.org/org/foundation/staff/) for their tireless efforts and especially | ||
| [Frederic Gurr](https://github.com/fredg02) and [Sébastien Heurtematte](https://github.com/heurtematte) for not only keeping all that infrastructure going but also constantly improving it. | ||
| [Frederic Gurr](https://github.com/fredg02), [Sébastien Heurtematte](https://github.com/heurtematte) and [Paweł Stankiewicz](https://github.com/pstankie) for not only keeping all that infrastructure going but also constantly improving it. |
There was a problem hiding this comment.
The punctuation in this 3-name list is inconsistent (comma after the first name but not after the second). Consider either removing the first comma or using consistent list punctuation (e.g., comma-separating all names, optionally with a serial/Oxford comma before the final “and”).
| [Frederic Gurr](https://github.com/fredg02), [Sébastien Heurtematte](https://github.com/heurtematte) and [Paweł Stankiewicz](https://github.com/pstankie) for not only keeping all that infrastructure going but also constantly improving it. | |
| [Frederic Gurr](https://github.com/fredg02), [Sébastien Heurtematte](https://github.com/heurtematte), and [Paweł Stankiewicz](https://github.com/pstankie) for not only keeping all that infrastructure going but also constantly improving it. |
There was a problem hiding this comment.
Is this really something that's done in English?
At least as for me a native German speaker, this seems weird.
There was a problem hiding this comment.
How you have it is ok. But a lot of people (me included) prefer the oxford comma in many situations as it disambiguates.
Consider either removing the first comma
I think copilot is wrong with this option though - the first comma should (almost) always be there.
There was a problem hiding this comment.
Yes, I in general a, b, and c is better than a, b and c.
There was a problem hiding this comment.
Added it.
Thanks for the elaboration.
The German Wikipedia says it's even in English (for some) a very controversial topic.
No description provided.