feat: provide on-pr workflow for all the basics checks that we need #89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| repo="${1:?Repository path is required}" | ||
|
|
||
| if ! [[ -f "$repo/MODULE.bazel" || -f "$repo/WORKSPACE" || -f "$repo/WORKSPACE.bazel" ]]; then | ||
| echo "ERROR: Not a Bazel workspace; you cannot run this script here." >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if ! command -v bazel >/dev/null 2>&1; then | ||
| echo "ERROR: bazel is not available on PATH; you need that to run this script." >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ -z "${GITHUB_OUTPUT:-}" ]]; then | ||
| echo "WARNING: This action is designed to be used in a GitHub Actions workflow. Running in 'local mode'." >&2 | ||
| GITHUB_OUTPUT=/dev/stdout | ||
| fi | ||
|
|
||
| echo "::group:: Detecting Bazel targets" | ||
|
|
||
| # Runs a boolean-style check function and writes to GITHUB_OUTPUT. | ||
| emit_output() { | ||
| local name="$1" | ||
| shift | ||
|
|
||
| if "$@"; then | ||
| echo "$name=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "$name=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| } | ||
|
|
||
| # Returns success if the given Bazel label can be queried from the repo root. | ||
| has_bazel_target() { | ||
| local target="$1" | ||
|
|
||
| ( | ||
| cd "$repo" | ||
| bazel query "$target" >/dev/null 2>&1 | ||
| ) | ||
| } | ||
|
|
||
| emit_output has_copyright_check has_bazel_target "//:copyright.check" | ||
| emit_output has_format_check has_bazel_target "//:format.check" | ||
|
|
||
| echo "::endgroup::" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| repo="${1:?Repository path is required}" | ||
| if [[ -z "${GITHUB_OUTPUT:-}" ]]; then | ||
| echo "WARNING: This action is designed to be used in a GitHub Actions workflow. Running in 'local mode'." >&2 | ||
| GITHUB_OUTPUT=/dev/stdout | ||
| fi | ||
|
|
||
| echo "::group:: Detecting repository capabilities" | ||
|
|
||
| # Runs a boolean-style check function and writes to GITHUB_OUTPUT. | ||
| emit_output() { | ||
| local name="$1" | ||
| shift | ||
|
|
||
| if "$@"; then | ||
| echo "$name=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "$name=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| } | ||
|
|
||
| # Returns success if any provided file path exists. | ||
| any_file_exists() { | ||
| local path | ||
| for path in "$@"; do | ||
| [[ -f "$path" ]] && return 0 | ||
| done | ||
| return 1 | ||
| } | ||
|
|
||
| # Returns success only if every provided file path exists. | ||
| all_files_exist() { | ||
| local path | ||
| for path in "$@"; do | ||
| [[ -f "$path" ]] || return 1 | ||
| done | ||
| return 0 | ||
| } | ||
|
|
||
| emit_output has_bazel any_file_exists \ | ||
| "$repo/MODULE.bazel" \ | ||
| "$repo/WORKSPACE" \ | ||
| "$repo/WORKSPACE.bazel" | ||
| emit_output has_bazel_lock any_file_exists \ | ||
| "$repo/MODULE.bazel.lock" | ||
| emit_output has_devcontainer any_file_exists \ | ||
| "$repo/.devcontainer/devcontainer.json" \ | ||
| "$repo/devcontainer.json" | ||
| emit_output has_python_uv all_files_exist \ | ||
| "$repo/pyproject.toml" \ | ||
| "$repo/uv.lock" | ||
| emit_output has_precommit any_file_exists \ | ||
| "$repo/.pre-commit-config.yaml" | ||
|
|
||
| echo "::endgroup::" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if a job from
on-pr.ymlfails? I assume this one also fails.I am asking because here I coded extra logic to check for failed jobs: https://github.com/eclipse-score/module_template/pull/57/changes#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR42-R62
Now I wonder if I could have achieved the same by using yet another workflow file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Potentially yeah, the same can be achieved via another indirection. Let's try that after this PR is merged?!