Adopt sanitizers from @score_cpp_policies#182
Open
RSingh1511 wants to merge 5 commits intoeclipse-score:mainfrom
Open
Adopt sanitizers from @score_cpp_policies#182RSingh1511 wants to merge 5 commits intoeclipse-score:mainfrom
RSingh1511 wants to merge 5 commits intoeclipse-score:mainfrom
Conversation
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
89f4eed to
06f8f78
Compare
RSingh1511
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
06f8f78 to
9efe87c
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
9efe87c to
0cf7b35
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
0cf7b35 to
b1978f6
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
b1978f6 to
28ebb8a
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
28ebb8a to
e71f80a
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
e71f80a to
cbf77bf
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
rmaddikery
reviewed
Mar 12, 2026
rmaddikery
reviewed
Mar 12, 2026
| cc_test( | ||
| name = "tsan_fail_data_race", | ||
| srcs = ["tsan_fail_data_race.cpp"], | ||
| # Re-package suppressions from @score_cpp_policies for integration testing |
Contributor
There was a problem hiding this comment.
why re-package here?
OK in case the repo has its own suppressions..?
Author
There was a problem hiding this comment.
re-packaging is needed for integration tests running in Docker so the suppression files from @score_cpp_policies are available at /sanitizers/suppressions/
Contributor
There was a problem hiding this comment.
We should have a way to specify our suppressions in this repository. There might be some that can be centralized (stdlib ones for example) but we will likely have some here that are exlusive to this repository.
Author
There was a problem hiding this comment.
Added repo-specific suppression files that merge with centralized ones from @score_cpp_policies in integration tests
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
cbf77bf to
de6f1df
Compare
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
had a problem deploying
to
workflow-approval
GitHub Actions
Error
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
5d9465d to
3f5b905
Compare
LittleHuba
reviewed
Mar 25, 2026
quality/sanitizer/sanitizer.bazelrc
Outdated
| test:tsan --linkopt -fsanitize-link-c++-runtime | ||
| test:tsan --platform_suffix=tsan | ||
| test:tsan --cxxopt=-O1 | ||
| test:tsan --test_tag_filters=-no-tsan |
Contributor
There was a problem hiding this comment.
We should decide on one way:
Either tagging or target_compatible_with.
I prefer the latter since it is more expressive in the targets and is not susceptible to typos.
Author
There was a problem hiding this comment.
Done. replaced all --test_tag_filters in .bazelrc with target_compatible_with
# Conflicts: # .bazelrc
RSingh1511
force-pushed
the
rs/swp-249901
branch
2 times, most recently
from
5be026d to
6372e0a
Compare
LittleHuba
reviewed
Mar 25, 2026
quality/sanitizer/sanitizer.bazelrc
Outdated
| test:tsan --linkopt -fsanitize=thread | ||
| test:tsan --linkopt -fsanitize-link-c++-runtime | ||
| test:tsan --platform_suffix=tsan | ||
| test:tsan --cxxopt=-O1 |
Contributor
There was a problem hiding this comment.
This should also go to the central feature. It is a recommended setting of Clang for ThreadSanitizer runs.
See usage section here: https://clang.llvm.org/docs/ThreadSanitizer.html
Comment on lines
+18
to
20
| # Debug symbols for sanitizer stack traces | ||
| test:with_debug_symbols --cxxopt=-g1 | ||
| test:with_debug_symbols --strip=never |
Contributor
There was a problem hiding this comment.
This should also go to the central cc_feature.
Without this sanitizer outputs are without symbol resolution. Debugging is then nearly impossible.
RSingh1511
force-pushed
the
rs/swp-249901
branch
9 times, most recently
from
cf56b3a to
042d217
Compare
RSingh1511
requested review from
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
10 tasks
RSingh1511
force-pushed
the
rs/swp-249901
branch
from
042d217 to
747dd91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.