Add GetLatestSlot and GetLatestSample functionality#208
Draft
muhseth wants to merge 4 commits intoeclipse-score:mainfrom
Draft
Add GetLatestSlot and GetLatestSample functionality#208muhseth wants to merge 4 commits intoeclipse-score:mainfrom
muhseth wants to merge 4 commits intoeclipse-score:mainfrom
Conversation
- Adds GetLatestSlot function to EventDataControlComposite Issue: SWP-249517
- Adds GetLatestSampleFunction to SkeletonEvent Issue: SWP-249517
- fixes clang format issues. Issue: SWP-249517
muhseth
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
castler
changed the title
Contributor
|
@muhseth please fix conflicts. |
crimson11
requested changes
Mar 26, 2026
| } | ||
|
|
||
| template <template <class> class AtomicIndirectorType> | ||
| score::cpp::optional<SlotIndexType> EventDataControlCompositeImpl<AtomicIndirectorType>::FindLatestReadableSlotIndex( |
Contributor
There was a problem hiding this comment.
You should instead change existing EventDataControlCompositeImpl::GetLatestTimestamp()! You are mostly duplicating code here. The new/refactored function should be named GetLatestSlot and it should return the index PLUS the timestamp!
And please take into account, what I have written here: https://jira.cc.bmwgroup.net/browse/SWP-253464
| slot_index < static_cast<SlotIndexType>(control.state_slots_.size()); | ||
| ++slot_index) | ||
| { | ||
| SCORE_LANGUAGE_FUTURECPP_ASSERT_PRD(static_cast<std::size_t>(slot_index) < control.state_slots_.size()); |
Contributor
There was a problem hiding this comment.
? Why this assert? I do not get it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.