Suya lola field support implement skeleton field set handler#209
Merged
castler merged 5 commits intoeclipse-score:mainfrom Mar 27, 2026
Conversation
Implement RegisterSetHandler() method to allow users to register callbacks for handling remote Set requests on skeleton fields. Issue: SWP-249527
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
2 times, most recently
from
6dddc3a to
aa0d381
Compare
Fix testcases failing due to missing implementation of pure virtual IsSetHandlerRegistered Issue: SWP-249527
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
from
aa0d381 to
ff9ef7d
Compare
soldier-sky
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
muhseth
reviewed
Mar 23, 2026
Fix the move semantics issue in RegisterSetHandler and add unit test to verify the fix. Issue: SWP-249527
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
from
d7143ea to
855558b
Compare
crimson11
requested changes
Mar 24, 2026
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
2 times, most recently
from
ccdbe71 to
7e13ac5
Compare
crimson11
requested changes
Mar 26, 2026
Unpdate and enforce callable signature for RegisterSetHandler Issue: SWP-249527
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
from
7e13ac5 to
83d533d
Compare
crimson11
requested changes
Mar 26, 2026
crimson11
requested changes
Mar 26, 2026
Fix review comments on internal handler Issue: SWP-249527
soldier-sky
force-pushed
the
suya_Lola_Field_Support_Implement_SkeletonField_Set_Handler
branch
from
e061877 to
29f7f19
Compare
crimson11
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement RegisterSetHandler() method to allow users to register callbacks for handling remote Set requests on skeleton fields. The Set handler wraps user-provided validation/modification logic and automatically broadcasts accepted values to all field subscribers via Update().
Issue: SWP-249527