Rust::com COM-API Error reporting optimization#230
Rust::com COM-API Error reporting optimization#230bharatGoswami8 wants to merge 7 commits intoeclipse-score:mainfrom
Conversation
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bharatGoswami8
force-pushed
the
COM-API_Error_Optimization
branch
from
2ce2401 to
0a512bf
Compare
bharatGoswami8
force-pushed
the
COM-API_Error_Optimization
branch
3 times, most recently
from
805507c to
3c65550
Compare
| panic!( | ||
| "InstanceSpecifier::ANY is not supported in LolaRuntimeImpl, | ||
| Please use FindServiceSpecifier::Specific with a valid instance specifier." | ||
| ); |
There was a problem hiding this comment.
Don't really get that point. C++ side supports ANY semantics. But consumers are always just for one specific instance. The resolution from ANY to specific instances happens in the SD.
There was a problem hiding this comment.
So this is supporting API for a API which enable user to get all the available services and user can iterate with each service and identify required service using InstanceSpecifier.
But as Primary API is not enabled in this case due to LoLa does not support find service call with ANY, it require specific InstanceSpecifier because of that this msg displayed to user.
| FindServiceSpecifier::Any => panic!( | ||
| "FindServiceSpecifier::Any is not supported in LolaRuntimeImpl, | ||
| Please use FindServiceSpecifier::Specific with a valid instance specifier." | ||
| ), |
There was a problem hiding this comment.
A ticket for this would be good.
There was a problem hiding this comment.
Yes sure i can create ticket to keep track if LoLa adds the ANY support for find service call then we will add in rust library also.
* Error id based on the use cases * Optimized the error handling on runtime impl * Example app handle the error
* Updated Error enums and removed string from variant
* Created ErrorDisplay macro for display and debug trait impl for enum * Optimized error module
* Added thiserror crate for display of Error msg
* Overrite the commit id for score_crate
* Updated Example app * Producer Builder error returning update
* score crate version update
bharatGoswami8
force-pushed
the
COM-API_Error_Optimization
branch
from
5fade72 to
c578d66
Compare
2 participants
#165