Use raw pointer and allocate instead of construct for creating memory for GenericSkeletonEvent#247
Draft
Use raw pointer and allocate instead of construct for creating memory for GenericSkeletonEvent#247
Conversation
In this case, we want to create a type erased byte array. Construct is used to allocate memory and instantiate a type in the allocated memory. In this case, we only want to allocate the memory. Therefore, instead of using construct with a dummy template type to force the correct alignment to be used, we simply use allocate.
Since the pointer to the type erased memory buffer which is returned by RegisterGeneric never resides in shared memory, there's no reason to not simply use a raw pointer.
bemerybmw
force-pushed
the
brem_fix_generic_skeleton
branch
from
6c432df to
7f5a8c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.