Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Contributor
Author
|
I fear the whole any_folder concept is broken in combination with combo builds. As any_folder relies on configuration in conf.py, this configuration is ignored when included in a combo build as external source. Potential way out: any_folder works recursively and reads conf.py. Then we use it for docs_combo instead of sphinx_collections. Reading foreign conf.py files is scary though. |
|
The created documentation from the pull request is available at: docu-html |
fcdf69d to
5576bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
The fix turns any_folder from clever little hack into a complex beast.
So, I added a concept page to explain that: https://eclipse-score.github.io/docs-as-code/pr-450/concepts/any_folder.html
🚨 Impact Analysis
✅ Checklist