Skip to content

Remove Deadline and Logical Supervisions from Launch Manager #128

Open
paulquiring wants to merge 2 commits intoeclipse-score:mainfrom
etas-contrib:feature/remove-logical-deadline-supervision
Open

Remove Deadline and Logical Supervisions from Launch Manager #128
paulquiring wants to merge 2 commits intoeclipse-score:mainfrom
etas-contrib:feature/remove-logical-deadline-supervision

Conversation

@paulquiring
Copy link
Copy Markdown
Contributor

@paulquiring paulquiring commented Mar 26, 2026

Deadline and Logical Supervision are obsolete in the Launch Manager now, as they are handled within the health monitoring library within the application process.

Closes: #130

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 83b7d6bc-6f55-4d79-b562-a0829f9bc00e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (37 packages loaded, 9 targets configured)

Analyzing: target //:license-check (89 packages loaded, 9 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2430 targets configured)

Analyzing: target //:license-check (154 packages loaded, 5202 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7872 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (166 packages loaded, 8025 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[12 / 16] [Sched] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.523s, Critical Path: 2.86s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

"hmSupervisionCheckpoint": [],
"hmAliveSupervision": [],
"hmDeadlineSupervision": [],
"hmLogicalSupervision": [],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove

"hmDeadlineSupervision": [],
"hmLogicalSupervision": [],

from the other expected output files

hmMonitorInterface: [HmMonitorInterface] (id:3);
hmSupervisionCheckpoint: [HmSupervisionCheckpoint] (id:4);
hmAliveSupervision: [HmAliveSupervision] (id:5);
hmDeadlineSupervision: [HmDeadlineSupervision] (id:6);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt score_inc_lifecycle/scripts/config_mapping/lifecycle_config.py to remove generation of the empty hmDeadlineSupervision and hmLogicalSupervision arrays so that it fits to the flatbuffer schema again.

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Deadline and Logical Supervision in LaunchManager code

2 participants