Draft
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Pull request overview
This PR extends the health monitoring library’s C++ test coverage by porting/expanding previously Rust-side unit tests into C++ and updates the Rust↔C++ FFI for HealthMonitorBuilder::build to accept optional cycle intervals.
Changes:
- Updated
health_monitor_builder_buildFFI to take nullable*const u64/const uint64_t*cycle interval parameters (null = use Rust defaults). - Added/expanded C++ gtest coverage for
HealthMonitorBuilder/HealthMonitorAPIs and introduced a new “integrated” usage test file. - Updated Rust-side FFI unit tests to use the new optional-parameter calling convention.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/health_monitoring_lib/rust/ffi.rs |
Changes the exported FFI signature for health_monitor_builder_build to nullable *const u64 and updates/extends unit tests accordingly. |
src/health_monitoring_lib/rust/deadline/ffi.rs |
Updates tests to call health_monitor_builder_build with null cycle interval pointers. |
src/health_monitoring_lib/rust/heartbeat/ffi.rs |
Updates tests to call health_monitor_builder_build with null cycle interval pointers. |
src/health_monitoring_lib/rust/logic/ffi.rs |
Updates tests to call health_monitor_builder_build with null cycle interval pointers. |
src/health_monitoring_lib/cpp/include/score/hm/health_monitor.h |
Stores cycle intervals as optionals to support passing nullable parameters over FFI. |
src/health_monitoring_lib/cpp/health_monitor.cpp |
Passes optional cycle intervals across FFI as nullable pointers. |
src/health_monitoring_lib/cpp/tests/health_monitor_test.cpp |
Replaces the previous “single integrated test” with a broader set of focused unit tests. |
src/health_monitoring_lib/cpp/tests/integrated_test.cpp |
Adds a higher-level integration-style test demonstrating multi-monitor setup and basic interactions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c1a1cf to
9974c3a
Compare
9974c3a to
219214f
Compare
219214f to
7697a8d
Compare
Expose parameters to background thread.
- Rename previous test to `integrated_test`. - Reimplement Rust unit tests into C++.
7697a8d to
1863fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integrated_test.Resolves #121