Skip to content

Comments

lttng: detect ctf2 kernel traces as kernel traces#372

Merged
arfio merged 1 commit intoeclipse-tracecompass:masterfrom
arfio:lttng-ctf2-detect
Feb 20, 2026
Merged

lttng: detect ctf2 kernel traces as kernel traces#372
arfio merged 1 commit intoeclipse-tracecompass:masterfrom
arfio:lttng-ctf2-detect

Conversation

@arfio
Copy link
Contributor

@arfio arfio commented Feb 16, 2026

What it does

Detect lttng CTF2 kernel traces as linux kernel traces.

How to test

Open a CTF2 lttng trace.

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Summary by CodeRabbit

  • Bug Fixes
    • Fixed domain validation to accept both standard and quoted kernel domain identifiers in trace configuration.

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request modifies domain validation logic in LttngKernelTrace.validate() to accept both "kernel" and ""kernel"" as valid domain values, relaxing the previous constraint that only allowed the quoted variant.

Changes

Cohort / File(s) Summary
Domain Validation
lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/lttng2/kernel/core/trace/LttngKernelTrace.java
Updated domain validation to accept both unquoted ("kernel") and quoted (""kernel"") domain values, while still rejecting null and other values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A kernel trace, both quoted and plain,
Now passes validation without strain,
Whether "kernel" or its quoted twin,
Both pathways welcome, let traces begin! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'lttng: detect ctf2 kernel traces as kernel traces' directly addresses the main change: extending domain validation to recognize CTF2 kernel traces, which aligns with the PR objective of detecting LTTng CTF2 kernel traces as Linux kernel traces.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arfio arfio merged commit f4dc97d into eclipse-tracecompass:master Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants