Skip to content

Crash at startup when local storage directory is not writable #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netomi merged 8 commits into from
Feb 11, 2026
Merged

Crash at startup when local storage directory is not writable #1603

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ad91f6
Fail fast at startup if local storage directory is not writable
Pranav-0440 Feb 10, 2026
413e847
Harden startup validation for local storage directory
Pranav-0440 Feb 10, 2026
53b4f06
Use Files.isWritable to validate local storage permissions
Pranav-0440 Feb 11, 2026
ffe8d98
Remove duplicate Java settings in VS Code
netomi Feb 11, 2026
d8e2f16
Fix JSON formatting in settings.json
netomi Feb 11, 2026
c6c4de1
Update settings.json
netomi Feb 11, 2026
8079058
Fix duplicate import in LocalStorageService
netomi Feb 11, 2026
6cf3d39
simplify logic
netomi Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions server/src/main/java/org/eclipse/openvsx/storage/LocalStorageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
* ****************************************************************************** */
package org.eclipse.openvsx.storage;

import java.io.IOException;
import java.net.URI;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.ArrayList;
import java.util.List;

import jakarta.annotation.PostConstruct;

Comment on lines 10 to 19
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no blank line between the package declaration and the first import. Other classes in this package keep a blank line after package ...; (e.g., AwsStorageService.java:11-13), and this can trip formatting/checkstyle rules.

Copilot uses AI. Check for mistakes.
import org.apache.commons.lang3.StringUtils;
import org.eclipse.openvsx.entities.FileResource;
import org.eclipse.openvsx.entities.Namespace;
Expand All @@ -22,14 +32,6 @@
import org.springframework.web.server.ServerErrorException;
import org.springframework.web.servlet.mvc.method.annotation.StreamingResponseBody;

import java.io.IOException;
import java.net.URI;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.ArrayList;
import java.util.List;

@Component
public class LocalStorageService implements IStorageService {

Expand All @@ -40,6 +42,27 @@ public class LocalStorageService implements IStorageService {
public boolean isEnabled() {
return !StringUtils.isEmpty(storageDirectory);
}

@PostConstruct
public void validateStorageDirectory() throws IOException {
if (!isEnabled()) {
return;
}

var storageDirectoryPath = Path.of(storageDirectory).toAbsolutePath();

if (!Files.exists(storageDirectoryPath)) {
Files.createDirectories(storageDirectoryPath);
}

if (!Files.isDirectory(storageDirectoryPath)) {
throw new IllegalStateException("Local storage directory '" + storageDirectory + "' is not a directory");
}

if (!Files.isWritable(storageDirectoryPath)) {
throw new IllegalStateException("Local storage directory '" + storageDirectory + "' is not writable");
}
}
Comment on lines 46 to 65
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces new startup behavior (fail-fast validation) but there are no focused tests exercising the writable vs non-writable cases for local storage. Given the existing test coverage for other storage services, it would be good to add tests that assert the app context fails to start (or the validator throws) when the directory is not writable, and succeeds when it is.

Copilot uses AI. Check for mistakes.

@Override
public void uploadFile(TempFile tempFile) {
Expand Down
Loading