Skip to content

[1890][eval] Move MergeReader to own module#1892

Open
mtar wants to merge 3 commits intoecmwf:developfrom
mtar:1890-mergereader-module
Open

[1890][eval] Move MergeReader to own module#1892
mtar wants to merge 3 commits intoecmwf:developfrom
mtar:1890-mergereader-module

Conversation

@mtar
Copy link
Contributor

@mtar mtar commented Feb 20, 2026

Description

This PR moves the WeatherGenMergeReader to a new module inside the evaluation package.

Additional changes on the class:

  • move json part of method load_scores to a private method and check that scores are loaded for all selected runs
  • more info added when readers are loaded
  • docstring update

Issue Number

Closes #1890

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@mtar mtar marked this pull request as ready for review February 20, 2026 13:10
@github-actions github-actions bot added the eval anything related to the model evaluation pipeline label Feb 23, 2026
@mtar mtar changed the title [1890][eval] Creates merge_reader.py [1890][eval] Move MergeReader to own module Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

move MergeReader

1 participant