Open
Conversation
4 tasks
mtar
commented
Feb 24, 2026
Comment on lines
-267
to
-290
| def _rename_channels(data) -> pd.DataFrame: | ||
| """ | ||
| The scores downloaded from Quaver have a different convention. Need renaming. | ||
| Rename channel names to include underscore between letters and digits. | ||
| E.g., 'z500' -> 'z_500', 't850' -> 't_850', '2t' -> '2t', '10ff' -> '10ff' | ||
|
|
||
| Parameters | ||
| ---------- | ||
| name : | ||
| Original channel name. | ||
|
|
||
| Returns | ||
| ------- | ||
| Dataset with renamed channel names. | ||
| """ | ||
| for name in list(data.index): | ||
| # If it starts with digits (surface vars like 2t, 10ff) → leave unchanged | ||
| if re.match(r"^\d", name): | ||
| continue | ||
|
|
||
| # Otherwise, insert underscore between letters and digits | ||
| data = data.rename(index={name: re.sub(r"([a-zA-Z])(\d+)", r"\1_\2", name)}) | ||
|
|
||
| return data |
Contributor
Author
There was a problem hiding this comment.
Is this function still needed? No reference can be found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the docstrings in the CsvReader class. The original logic for handling empty data has been fixed.
Issue Number
Closes #1893
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60