Skip to content

Fix/z3fdb bugs#226

Merged
Ozaq merged 3 commits intodevelopfrom
fix/z3fdb-bugs
Feb 19, 2026
Merged

Fix/z3fdb bugs#226
Ozaq merged 3 commits intodevelopfrom
fix/z3fdb-bugs

Conversation

@Ozaq
Copy link
Copy Markdown
Member

@Ozaq Ozaq commented Feb 12, 2026

Description

Addresses 3 slammer z3fdb issues:

FDB-619, FDB-634, FDB-632

Commits

    Better error on z3fdb view creation error

    When constructing a z3fdb view the build access one grib message to
    establish field size. If this data was not found the exception from FDB
    is passed on. This commit catches and rethrows the exception with a
    error message that is better to understand for users of z3fdb.

    Fixes: FDB-619
---
    Add bounds check to ChunkedDataView::at

    Fixes: FDB-634
---
    Refactor to proper pep8 naming

    extendOnAxis -> extend_on_axis

    Fixes: FDB-632
---

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-226

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-226

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.55%. Comparing base (8f06994) to head (96f4097).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
tests/chunked_data_view/test_view.cc 93.47% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
+ Coverage    73.32%   73.55%   +0.23%     
===========================================
  Files          363      363              
  Lines        21976    22044      +68     
  Branches      2259     2260       +1     
===========================================
+ Hits         16113    16214     +101     
+ Misses        5863     5830      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@tbkr tbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the error checking. This was needed. The CI is currently failing. Once this has been fixed the PR can be merged.

@Ozaq Ozaq force-pushed the fix/z3fdb-bugs branch 2 times, most recently from 457e624 to bb5658f Compare February 17, 2026 10:38
Ozaq added 3 commits February 19, 2026 13:12
extendOnAxis -> extend_on_axis

Fixes: FDB-632
When constructing a z3fdb view the build access one grib message to
establish field size. If this data was not found the exception from FDB
is passed on. This commit catches and rethrows the exception with a
error message that is better to understand for users of z3fdb.

Fixes: FDB-619
@Ozaq Ozaq merged commit 2a648d1 into develop Feb 19, 2026
9 checks passed
@Ozaq Ozaq deleted the fix/z3fdb-bugs branch February 19, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants