Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #226 +/- ##
===========================================
+ Coverage 73.32% 73.55% +0.23%
===========================================
Files 363 363
Lines 21976 22044 +68
Branches 2259 2260 +1
===========================================
+ Hits 16113 16214 +101
+ Misses 5863 5830 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tbkr
requested changes
Feb 13, 2026
Contributor
tbkr
left a comment
There was a problem hiding this comment.
Thanks for implementing the error checking. This was needed. The CI is currently failing. Once this has been fixed the PR can be merged.
457e624 to
bb5658f
Compare
extendOnAxis -> extend_on_axis Fixes: FDB-632
Fixes: FDB-634
When constructing a z3fdb view the build access one grib message to establish field size. If this data was not found the exception from FDB is passed on. This commit catches and rethrows the exception with a error message that is better to understand for users of z3fdb. Fixes: FDB-619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses 3 slammer z3fdb issues:
FDB-619, FDB-634, FDB-632
Commits
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-226
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-226