refactor(worker): move build info into service crates #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralize build metadata in service crates so controller/worker startup and tests pass build info explicitly without config coupling. - Add admin_api::build_info::BuildInfo and re-export it from controller - Introduce worker::build_info::BuildInfo with serde/db conversions and remove worker_info from worker::config::Config - Thread BuildInfo into worker/controller startup with Into<BuildInfo> conversions - Add test build script and tests::testlib::build_info using vergen metadata Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
Contributor
Author
|
Here’s the reverse dependency tree (crates that depend on it) after the PR: |
LNSD
force-pushed
the
lnsd/refactor-config-build-info-break-dep
branch
from
6f267cc to
a3d10d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize build metadata in service crates so controller/worker startup and tests pass build info explicitly without config coupling.
admin_api::build_info::BuildInfoand re-export it fromcontrollerservice crateworker::build_info::BuildInfowith serde/db conversions and remove worker_info fromworker::config::ConfigBuildInfointo worker/controller startup withInto<BuildInfo>conversionstests::testlib::build_infousing vergen metadata