Draft
Conversation
c82f3f1 to
c508ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds freshness tracking for dump jobs via two new metrics:
latest_segment_timestamp: Unix timestamp of the end block in the most recentlywritten segment
latest_segment_delay_seconds: Difference between latest_segment_timestamp and wallclock time at write
For derived datasets, freshness is recorded inline when a segment is written, since writes are sequential.
For raw datasets it's more involved: multiple writers dump disjoint block ranges in parallel, so recording freshness at write time would give inconsistent values depending on which writer finishes last. Instead, a background task subscribes to table change notifications and reports freshness based on
synced_range.Commits:
metadata.
time).