refactor(controller): merge admin-api crate into controller#2045
Merged
Conversation
Eliminate the admin-api indirection layer since controller is its sole consumer, absorbing routing, context, and handler modules directly. - Move `ctx`, `build_info`, `handlers` modules from `admin-api` into `controller` - Extract `router()` and OpenAPI spec generation into new `router.rs` module - Merge all `admin-api` dependencies and `utoipa` feature into controller - Move gen crate to `controller/gen/` and rename to `amp-controller-admin-api-gen` - Update justfile openapi gen tasks to reference new crate name Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-controller-openapi-gen
branch
from
cf51b74 to
2d35877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the admin-api indirection layer since controller is its sole consumer, absorbing routing, context, and handler modules directly.
ctx,build_info,handlersmodules fromadmin-apiintocontrollerrouter()and OpenAPI spec generation into newrouter.rsmoduleadmin-apidependencies andutoipafeature into controllercontroller/gen/and rename toamp-controller-admin-api-gen