Skip to content

fix(common): remove incorrect _block_num statistics injection #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Theodus merged 1 commit into from
Mar 30, 2026
+2 −16
Merged

fix(common): remove incorrect _block_num statistics injection #2047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions crates/core/common/src/catalog/physical/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use amp_parquet::reader;
use datafusion::{
arrow::datatypes::SchemaRef,
catalog::{Session, memory::DataSourceExec},
common::{DFSchema, ScalarValue, project_schema, stats::Precision},
common::{DFSchema, project_schema, stats::Precision},
datasource::{
TableProvider, TableType, create_ordering,
listing::{ListingTableUrl, PartitionedFile},
Expand Down Expand Up @@ -343,24 +343,10 @@ impl TableProvider for QueryableSnapshot {

let target_partitions = state.config_options().execution.target_partitions;
let table_schema = self.physical_table.schema();
let (file_groups, mut statistics) = self
let (file_groups, statistics) = self
.resolve_file_groups(&segments, target_partitions, table_schema.clone())
.await?;

// Override _block_num column statistics with exact min/max from synced_range.
// This enables the AggregateStatistics optimizer to resolve MIN/MAX(_block_num)
// as constants without scanning parquet files.
if let Some(range) = &self.synced_range
&& let Ok(idx) =
table_schema.index_of(datasets_common::block_num::RESERVED_BLOCK_NUM_COLUMN_NAME)
{
statistics.column_statistics[idx].null_count = Precision::Exact(0);
statistics.column_statistics[idx].min_value =
Precision::Exact(ScalarValue::UInt64(Some(range.start())));
statistics.column_statistics[idx].max_value =
Precision::Exact(ScalarValue::UInt64(Some(range.end())));
}

if statistics.num_rows == Precision::Absent {
tracing::warn!("Table has no row count statistics. Queries may be inefficient.");
}
Expand Down
Loading