Conversation
burgerdev
reviewed
Mar 11, 2026
| @@ -0,0 +1,113 @@ | |||
| // Copyright 2025 Edgeless Systems GmbH | |||
Member
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 Edgeless Systems GmbH | |
| // Copyright 2026 Edgeless Systems GmbH |
| unstructured, err := kuberesource.ResourcesToUnstructured(resources) | ||
| require.NoError(err) | ||
|
|
||
| // Restart whole statefulset so the owned configmap store is also deleted. |
Member
There was a problem hiding this comment.
Suggested change
| // Restart whole statefulset so the owned configmap store is also deleted. | |
| // Delete whole statefulset so the owned configmap store is also deleted. |
| // Wait until all objects are deleted before applying the resources again, | ||
| // otherwise some resources may be deleted after being reapplied. | ||
| require.NoError(ct.Kubeclient.WaitForDeletion(ctx, unstructured...)) | ||
| ct.Apply(t) |
Member
There was a problem hiding this comment.
Suggested change
| ct.Apply(t) | |
| require.True(t.Run("apply resources after deleting them", ct.Apply), "Kubernetes resources need to be applied for subsequent tests") |
| require.NoError(err) | ||
| require.NoError(ct.Kubeclient.Apply(ctx, historyUnstructured...)) | ||
|
|
||
| ct.Recover(t) |
Member
There was a problem hiding this comment.
Suggested change
| ct.Recover(t) | |
| t.Run("recover after restoring configmaps", ct.Recover) |
Comment on lines
+91
to
+104
| require.NoError(ct.RunSet(ctx, "--atomic")) | ||
|
|
||
| require.True(t.Run("verify", ct.Verify), "contrast verify needs to succeed for subsequent tests") | ||
|
|
||
| require.NoError(ct.RunSet(ctx, "--atomic")) | ||
|
|
||
| // Second set manifest does not have the correct latest transition hash. | ||
| require.ErrorContains(ct.RunSet(ctx, "--atomic"), "does not match latest state") | ||
|
|
||
| // Normal set manifest should still work. | ||
| require.NoError(ct.RunSet(ctx)) | ||
|
|
||
| require.NoError(ct.RunVerify(ctx)) | ||
| require.NoError(ct.RunSet(ctx, "--atomic")) |
Member
There was a problem hiding this comment.
Could you please add a negative and a positive test for an explicit transition flag?
davidweisse
force-pushed
the
dav/e2e-coordinator
branch
from
d30bfbb to
1c9f410
Compare
burgerdev
force-pushed
the
dav/e2e-coordinator
branch
from
1c9f410 to
09fc5d1
Compare
burgerdev
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an E2E test specifically for Coordinator related tasks where we don't need a full OpenSSL deployment but only the runtime and the Coordinator. For now, this includes testing atomic manifest updates and config map recovery.