Skip to content

internal.kuberesource: add MapPodSpec variants with error returns#2250

Merged
charludo merged 1 commit intomainfrom
ch/mapfn-with-errors
Mar 25, 2026
Merged

internal.kuberesource: add MapPodSpec variants with error returns#2250
charludo merged 1 commit intomainfrom
ch/mapfn-with-errors

Conversation

@charludo
Copy link
Copy Markdown
Collaborator

@charludo charludo commented Mar 13, 2026

Previously, running contrast generate on resources containing invalid, contrast-cc--prefixed runtime class names (for example, contrast-cc-invalidplatform) would silently fall back to using the default platform provided via --reference-values.

Starting with this PR, contrast generate will fail with an appropriate error message in these cases.

Please ensure that contrast-cc- runtime class names are referring to valid platforms, i.e. currently

  • contrast-cc-metal-qmeu-snp
  • contrast-cc-metal-qmeu-snp-gpu
  • contrast-cc-metal-qmeu-tdx, or simply use
  • contrast-cc.

@charludo charludo requested a review from katexochen March 13, 2026 08:03
@charludo charludo added the no changelog PRs not listed in the release notes label Mar 13, 2026
@burgerdev burgerdev self-assigned this Mar 24, 2026
Comment thread cli/cmd/generate.go
@charludo charludo added breaking change A user-affecting breaking change and removed no changelog PRs not listed in the release notes labels Mar 25, 2026
@charludo charludo force-pushed the ch/mapfn-with-errors branch from 28db1e4 to 8a5b3cf Compare March 25, 2026 07:41
@charludo charludo merged commit d651edb into main Mar 25, 2026
13 of 14 checks passed
@charludo charludo deleted the ch/mapfn-with-errors branch March 25, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A user-affecting breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants