Skip to content

feat(#003): feature users list#9

Merged
hectorguillen-blip merged 13 commits into7369-admin-angular-upgradefrom
feature/users-list
Mar 31, 2026
Merged

feat(#003): feature users list#9
hectorguillen-blip merged 13 commits into7369-admin-angular-upgradefrom
feature/users-list

Conversation

@hectorguillen-blip
Copy link
Copy Markdown

@hectorguillen-blip hectorguillen-blip commented Mar 23, 2026

Description

Creation of the Users List settings page as part of the new Angular admin tool.
Allows administrators to view and manage the list of users registered in the
application. Connects to the existing /api/v1/users API endpoints with session
cookie authentication.

Closes #XXXX

Code review checklist

  • UI/UX backwards compatible
  • Readable: Concise, well named, follows the style guide
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration
  • AI disclosure: No AI was used in this contribution

License

The software is provided under AGPL-3.0. Contributions to this project
are accepted under the same license.


**Feature/users list:**

feat(#3): add users list page

@hectorguillen-blip hectorguillen-blip changed the title feat(#002):Feature users list feat(#003):feature users list Mar 23, 2026
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.less Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.less Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.less Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.less Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.ts Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.ts Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.ts Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/services/users.service.ts Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/src/ts/services/users.service.ts Outdated
jomcarvajal
jomcarvajal reviewed Mar 25, 2026
View reviewed changes
Comment thread admin-tool/tests/karma/ts/modules/users/users-list.component.spec.ts
jomcarvajal
jomcarvajal requested changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@jomcarvajal jomcarvajal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you manage tests files 💯 I left some minor comments. Let me know if you're agree or if you want to discuss something! Also is it possible to add screenshots of the FE changes ? And the test-coverage of the new files ?

PD: Lint is failing in PR title. propably is expecting a space after colon

@jomcarvajal jomcarvajal mentioned this pull request Mar 25, 2026
Merged
3 tasks
@hectorguillen-blip hectorguillen-blip changed the title feat(#003):feature users list feat(#003): feature users list Mar 26, 2026
@hectorguillen-blip hectorguillen-blip self-assigned this Mar 26, 2026
jomcarvajal
jomcarvajal reviewed Mar 26, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
<div class="loader"></div>
}

@if (!loading) {
Copy link
Copy Markdown

@jomcarvajal jomcarvajal Mar 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use @else here. You're already calling @if (loading) so that means that if the code didn't enter there is because !loading is true

jomcarvajal
jomcarvajal reviewed Mar 26, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 26, 2026
View reviewed changes
Comment thread admin-tool/src/ts/modules/users/ts/components/users-list/users-list.component.html Outdated
jomcarvajal
jomcarvajal reviewed Mar 26, 2026
View reviewed changes
Comment thread admin-tool/tests/karma/ts/services/users.service.spec.ts
@hectorguillen-blip hectorguillen-blip changed the base branch from feature/authentication to 7369-admin-angular-upgrade March 26, 2026 22:03
jomcarvajal
jomcarvajal requested changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

@jomcarvajal jomcarvajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation. And Be sure all tests pass before merge

Comment thread admin-tool/package-lock.json
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
Copy link
Copy Markdown

@jomcarvajal jomcarvajal Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should have 0 changes taking into account you didn't modify the package.json

hectorguillen-blip and others added 12 commits March 30, 2026 15:42
@hectorguillen-blip
feat: implement users list with mock data and fix module imports
3f1595d
@hectorguillen-blip
Adding authentication logic
0b3ca91
@hectorguillen-blip
feat: implement users service and finalize users-list component
c7cbe24
@hectorguillen-blip
feat: implement users list view with permission guard and unit tests
519b83e
@hectorguillen-blip
fix: add missing newline at end of files
894da4a
@hectorguillen-blip
fix: apply PR feedback - buttons, @if/@for, translate, aria-labels, r…
e5cd381 
…em units, User interface, global variables
@hectorguillen-blip
style: fix indentation and code formatting
73ec07f
@hectorguillen-blip
fix: use single quotes in users service and spec
c9311d3
@hectorguillen-blip
fix: apply PR feedback - use @else, wrap columns in @if, fix empty us…
e3e8fba 
…ers iteration
@hectorguillen-blip
fix: remove duplicate bracket in app.config.ts after merge
b38e8af
@hectorguillen-blip
fix: use single quotes in app.config.ts
4baf713
@hectorguillen-blip
chore: rebase onto 7369-admin-angular-upgrade
58e61d5
@hectorguillen-blip hectorguillen-blip merged commit c349c05 into 7369-admin-angular-upgrade Mar 31, 2026
142 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jomcarvajal jomcarvajal jomcarvajal approved these changes

Assignees

@hectorguillen-blip hectorguillen-blip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hectorguillen-blip @jomcarvajal