setupClientCertifcate() Method added.#58
Open
drieschel wants to merge 2 commits intoeducoder:masterfrom
Open
Conversation
Author
|
I corrected it. Do I still have to do something else? It is my very first pull request. |
Contributor
|
I think certificates is a useful thing to consider in this library! |
Member
|
Looks okay to me. I worry about the client API getting a little unwieldily—we might want to think of some better strategy for doing configuration like this—but I'll leave it to one of the active maintainers to make the call on merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the Pest classes in a project and needed to authenticate using client certificates.