fix: breaking xqueue image builds#233
Merged
srathod-apphelix merged 1 commit intoedx:masterfrom Aug 11, 2025
jcapphelix:fix-xqueue-build
Merged
fix: breaking xqueue image builds#233srathod-apphelix merged 1 commit intoedx:masterfrom jcapphelix:fix-xqueue-build
srathod-apphelix merged 1 commit intoedx:masterfrom
jcapphelix:fix-xqueue-build
Conversation
srathod-apphelix
approved these changes
Aug 11, 2025
UsamaSadiq
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Jenkins build failure for the edxops/xqueue:latest Docker image by addressing virtualenv installation issues with Python 3.11. The build was broken due to the Python version upgrade from 3.8 to 3.11 and virtualenv compatibility problems during Docker image builds.
- Adds conditional installation of pip and virtualenv specifically for Docker builds using Python 3.11
- Introduces a new flag
xqueue_image_buildingto control Docker-specific tasks - Ensures virtualenv installation works properly during Docker image builds without affecting other services
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| playbooks/roles/xqueue/tasks/main.yml | Adds Docker-specific pip and virtualenv installation tasks for Python 3.11 |
| playbooks/roles/xqueue/defaults/main.yml | Introduces xqueue_image_building flag with default value false |
| docker/build/xqueue/ansible_overrides.yml | Sets xqueue_image_building to true for Docker builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes jenkins build of
edxops/xqueue:latestimage.Reason of breaking
There are 2 reasons of why this build was broken.
Fixes
While this PR was able to fix python 3.8 to 3.11 issue, the issue for virtualenv still persisted and the task was failing, mostly because of version issue for virtualenv.
As a solution I've installed virtualenv and pip separately when docker image is being built.
NOTE: This is only needed docker image is built and tasks are written with that condition, this is done to avoid having version conflicts with other services. Another thing to note is that the task only breaks when docker images are being built, which means that while in use with other services the virtualenv works properly, mostly because it'll get installed properly via
commontasks.Jira link