Fix error collision #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are four types of errors: - Unknown seed, - CRC mismatch, - Invalid types, - Execution time < 10s. All of these errors are handled by the 'total_errors' variable. However, handling of the 'unknown seed' error differs from other types: it sets 'total_errors' to -1, while other types of errors increment this variable. This behavior leads to situations where one error overrides another. For example, if you compile the program incorrectly and get an unknown seed, and then run the program for less than 10 seconds, you will get total_errors = 0 (because one error sets it to -1, while another increments it to 0). See eembc#4. As a result, you'll receive "Correct operation validated" when you shouldn't.
HepoH3
commented
Feb 11, 2026
| if (total_errors > 0) | ||
| ee_printf("Errors detected\n"); | ||
| if (total_errors < 0) | ||
| if (known_id < 0) |
Author
There was a problem hiding this comment.
The known_id variable is initialized by -1 and then it reassigned to positive value in switch(seedcrc) block of code. Thus, known_id < 0 is basically the same indicator as current check total_errors < 0, but without error type collision in total_errors variable.
Contributor
There was a problem hiding this comment.
Thanks for the details. I will look into this in a couple of weeks time.
Joseph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four types of errors:
All of these errors are handled by the 'total_errors' variable. However, handling of the 'unknown seed' error differs from other types: it sets 'total_errors' to -1, while other types of errors increment this variable.
This behavior leads to situations where one error overrides another. For example, if you compile the program incorrectly and get an unknown seed, and then run the program for less than 10 seconds, you will get total_errors = 0 (because one error sets it to -1, while another increments it to 0). See #4.
As a result, you'll receive "Correct operation validated" when you shouldn't.