Skip to content

Conversation

@Ty3uK
Copy link

@Ty3uK Ty3uK commented Jan 19, 2026

next@16.1 again messed up with swc_core version in minor version bump:

https://plugins.swc.rs/versions/range/768

I'm not a great Rust developer, so my code definitely can be bad.

Outdated information Also, can someone help me with checking `pnpm build --build --test`? It turns out that on my machine with ArchLinux I cannot successfully complete this command even on clean master: ``` ty3uk@archlinux ~/D/W/effector-swc-plugin (feature/swc_core@50)> pnpm build --test

@effector/swc-plugin@0.8.1 build /home/ty3uk/Dev/Work/effector-swc-plugin
node scripts/pack.mjs --test

==================
RUNNING: @latest
DONE

RUNNING: @swc0.96.9
Compiling swc_common v0.34.4
Compiling swc_error_reporters v20.0.0
error[E0432]: unresolved import serde::__private
--> /home/ty3uk/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swc_common-0.34.4/src/private/mod.rs:3:9
|
3 | pub use serde::__private as serde;
| ^^^^^^^---------^^^^^^^^^
| | |
| | help: a similar name exists in the module: private
| no __private in the root

Compiling testing v19.0.0
For more information about this error, try rustc --explain E0432.
error: could not compile swc_common (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile swc_common (lib) due to 1 previous error

node:internal/modules/run_main:107
triggerUncaughtException(
^
101
(Use node --trace-uncaught ... to show where the exception was thrown)

Node.js v24.11.1
 ELIFECYCLE  Command failed with exit code 1.

</details>

@Ty3uK
Copy link
Author

Ty3uK commented Jan 19, 2026

I managed to "fix" most of the problems with #[cfg], but I'm not sure in which direction I should move:

  • mark all new code with #[cfg(feature = "plugin_compat_v1.13.0")] and override swc_core in version-map.json
  • mark all new code with #[cfg(not(feature = "plugin_compat_v1.12.0"))] and override serde=1.0.219 in all versions except latest.

Maksim Karelov added 3 commits January 19, 2026 18:47
@kireevmp
Copy link
Collaborator

Hi! Appreciate you taking the time to open this. We actually began working toward the v1 release (see PR #37, with some commits back from November), and we've published a pre-release version v1.0.0-next.1 to NPM. Would you mind testing it with next@16.1 to see if that resolves the issue?

@Ty3uK
Copy link
Author

Ty3uK commented Jan 19, 2026

Would you mind testing it with next@16.1 to see if that resolves the issue?

It's working, thanks! I will close the PR then. 🙂

@Ty3uK Ty3uK closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants