src/lib.rs: EGraph readonly pub. accessors#827
src/lib.rs: EGraph readonly pub. accessors#827Muxianesty wants to merge 1 commit intoegraphs-good:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 81.53% 81.46% -0.08%
==========================================
Files 88 88
Lines 24157 24190 +33
==========================================
+ Hits 19697 19706 +9
- Misses 4460 4484 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
|
Hey @Muxianesty so far we have been trying to keep some of these interfaces private in order to not be responsible for breaking users code if we change them internally. Are there particular features that you need that are currently not exposed? |
|
@saulshanabrook Hey! I've mentioned a use-case of trying to access rulesets from user-defined commands in a read-only fashion in a Zulipchat thread. To be even more specific, I am trying to build a set of commands which allows to construct rulesets out of existing rules to overcome the limitations of: I've came to the same conclusion that these data structures are better left internal and currently trying to cope without them. |
Sounds good! If there end up being a few things that do need to be exposed to create custom schedules let us know. There are some custom schedules in experimental that rely on public APIs, so if they aren't enough we can extend them. The experimentation sounds interesting and am curious how it ends up working out. |
|
Seems like this can be closed? |
The following Pull Request introduces a number of read-only accessors to
EGraph.In order to preserve existing API no other function was changed.