Draft
Conversation
I had it in my local copy, and pushed and old commit yesterday before your suggestions. Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Accepted. Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
c-dilks
reviewed
Oct 11, 2023
src/test_pixel_gap_cuts.cpp
Outdated
| auto cellID = sim_hit.getCellID(); | ||
| auto pos = sim_hit.getPosition(); | ||
| auto mom = sim_hit.getMomentum(); | ||
| TVector3 p; p.SetX(mom.x); p.SetY(mom.y); p.SetZ(mom.z); |
Member
There was a problem hiding this comment.
Suggested change
| TVector3 p; p.SetX(mom.x); p.SetY(mom.y); p.SetZ(mom.z); | |
| TVector3 p(mom.x, mom.y, mom.z); |
Member
Author
There was a problem hiding this comment.
The one you suggested was what I tried for the first time. The compilation failed and it complained that this method not found (LoL) and so I had to move to SetX(). This morning I have updated my eic-shell, I will try once more.
chchatte92
force-pushed
the
normalIncidence
branch
from
a3396bc to
cd0356f
Compare
7 tasks
Member
|
With eic/EICrecon#1068 merged, is this ready? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
The PR tries to estimate the incidence angle of the impinging MC photons.
For the testing purpose I am just using the existic test_pixel_gap_cuts.cpp; will move to a total new code in case the procedure is right.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
@c-dilks is aware of the studies and he has been asked to kindly review the changes made in EICRecon to get the sensor normalZ.
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?