Skip to content

feat: Implement delete and share functionality in SearchHistoryDialog#1425

Open
Eruis2579 wants to merge 3 commits intoeigent-ai:mainfrom
Eruis2579:main
Open

feat: Implement delete and share functionality in SearchHistoryDialog#1425
Eruis2579 wants to merge 3 commits intoeigent-ai:mainfrom
Eruis2579:main

Conversation

@Eruis2579
Copy link

  • Implement handleDelete with API delete and local file cleanup via Electron IPC
  • Implement handleShare using share() from lib/share
  • Add delete/share dropdown to list view with Share2, Trash2, Ellipsis actions
  • Extend GroupedHistoryView onTaskDelete to pass task for file cleanup
  • Update ProjectDialog to pass task.task_id for share
  • Add delete-success and delete-failed locale keys
  • Update Projects page handleDelete signature for new interface

Testing Evidence

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

- Implement handleDelete with API delete and local file cleanup via Electron IPC
- Implement handleShare using share() from lib/share
- Add delete/share dropdown to list view with Share2, Trash2, Ellipsis actions
- Extend GroupedHistoryView onTaskDelete to pass task for file cleanup
- Update ProjectDialog to pass task.task_id for share
- Add delete-success and delete-failed locale keys
- Update Projects page handleDelete signature for new interface
Copy link
Collaborator

@bytecii bytecii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Eruis2579 Eruis2579 requested a review from bytecii March 4, 2026 12:41
@Eruis2579
Copy link
Author

Hi, @bytecii , Please review my PR

@Eruis2579
Copy link
Author

@bytecii , Please check my updates

1 similar comment
@Eruis2579
Copy link
Author

@bytecii , Please check my updates

@Eruis2579
Copy link
Author

@bytecii , Please check my updates. I really want your review

@Eruis2579
Copy link
Author

@bytecii , Please check my updates if you have time

@Eruis2579
Copy link
Author

@4pmtong , Please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants