Straight shot example - Divide by sqrt(2) instead of multiply#259
Straight shot example - Divide by sqrt(2) instead of multiply#259ekiefl merged 4 commits intoekiefl:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…arov/pooltool into fix-straight-shot-example
|
Thanks @a-sklyarov for your contribution :) I added a random seed so results are reproducible. Merging once checks pass. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 46.20% 46.20%
=======================================
Files 144 144
Lines 10290 10290
=======================================
Hits 4755 4755
Misses 5535 5535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To move a distance
Dalong the diagonal, we should divide bysqrt(2)instead of multiply to get the x and y. I adjusted the values fordandDto double what they were to keep the rest of the examples the same.