Skip to content

Straight shot example - Divide by sqrt(2) instead of multiply#259

Merged
ekiefl merged 4 commits intoekiefl:mainfrom
a-sklyarov:fix-straight-shot-example
Mar 14, 2026
Merged

Straight shot example - Divide by sqrt(2) instead of multiply#259
ekiefl merged 4 commits intoekiefl:mainfrom
a-sklyarov:fix-straight-shot-example

Conversation

@a-sklyarov
Copy link
Copy Markdown
Contributor

To move a distance D along the diagonal, we should divide by sqrt(2) instead of multiply to get the x and y. I adjusted the values for d and D to double what they were to keep the rest of the examples the same.

@a-sklyarov a-sklyarov requested a review from ekiefl as a code owner February 5, 2026 00:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab36f6a7-7cd7-4e6a-ba96-0d4052911e88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ekiefl
Copy link
Copy Markdown
Owner

ekiefl commented Mar 14, 2026

Thanks @a-sklyarov for your contribution :)

I added a random seed so results are reproducible. Merging once checks pass.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.20%. Comparing base (3e851b5) to head (fb0836f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   46.20%   46.20%           
=======================================
  Files         144      144           
  Lines       10290    10290           
=======================================
  Hits         4755     4755           
  Misses       5535     5535           
Flag Coverage Δ
service 46.20% <ø> (ø)
service-no-ani 56.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekiefl ekiefl merged commit 2ce530b into ekiefl:main Mar 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants