CI: Enable AOT analyzers on library projects, skip AOT publish on PRs#2971
Open
CI: Enable AOT analyzers on library projects, skip AOT publish on PRs#2971
Conversation
… PRs Add IsAotCompatible to 12 library projects referenced by docs-builder so Roslyn's trim/AOT analyzers (IL2026/IL3050) run during regular builds. This catches AOT issues at compile time, removing the need for the expensive native ILC publish step on pull requests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe pull request updates the CI/CD workflow to restrict publish and container steps to push events only, preventing these operations from running on other event types like pull requests. Additionally, all twelve project files across the solution now declare AOT (Ahead-of-Time) compatibility by adding the Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable Roslyn's AOT/trim analyzers on all library projects in the docs-builder dependency closure, and skip the native AOT publish step on pull requests.
Why
AOT/trim errors (IL2026/IL3050) only surfaced during the native ILC publish step in CI, not during local builds or the lint job. This made issues like anonymous-type serialization bugs invisible until the container publish stage.
How
<IsAotCompatible>true</IsAotCompatible>to 12 library projects that were missing it (5 already hadPublishAotwhich enables the same analyzers)github.event_name == 'push'so they only run on merges to main, not on PRsTest plan
🤖 Generated with Claude Code