Updates to OTel VPC Flow Log Dashboard + YAML Dashboard Validator#17358
Updates to OTel VPC Flow Log Dashboard + YAML Dashboard Validator#17358
Conversation
- Update version in manifest.yml from 0.1.1 to 0.2.0 - Add changelog entry documenting the VPC Flow Log dashboard updates Co-authored-by: Bill Easton <strawgate@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changelog PR link issue has already been flagged in an unresolved comment (line 5 of packages/aws_vpcflow_otel/changelog.yml - links to #16969 but should be #17358).
Previous review comments on the workflow file have been addressed:
- PyPI packages are now pinned to specific version (
@0.2.7) instead of@latest - The
diff -rcomparison approach was replaced with--exit-non-zero-on-changeflag
The implementation looks sound overall - the YAML dashboard validation workflow and the _dev folder removal for content packages follow existing patterns in the codebase.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
dashboard
teresaromero
left a comment
teresaromero
left a comment
There was a problem hiding this comment.
Changes lgtm, however i'd like to get some extra eyes 👀
|
@claude let's remove the _dev clean-up from this, we'll merge this after #17370 and we wont need the _dev cleanup anymore @mykola-elastic waiting on #17370 to merge i think |
|
Claude finished @strawgate's task in 1m 2s —— View job Removing _dev Cleanup Code
Done! Removed the Changes pushed in commit 87367c1. --- | View branch Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
This workaround is no longer needed after #17370 is merged, which adds support for _dev folders in content packages in the package spec. Co-authored-by: Bill Easton <strawgate@users.noreply.github.com>
|
@claude that pr i mentioned has landed, is this ready to go? |
|
Claude finished @strawgate's task in 2m 20s —— View job Checking PR Readiness
Status Summary: Yes, PR #17370 has been merged (on 2026-02-16), and I've verified the current state of this PR:
The PR is looking good. Once the Buildkite build passes, it should be ready to merge. The branch is up-to-date with main (merged in commit 210e5fd). I also resolved the outdated review thread from @mykola-elastic about the TODO reference - since that code was removed entirely when the --- | View branch Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
💚 Build Succeeded
History
|
|
Thanks @strawgate for the changes. Looks good! |
lalit-satapathy
left a comment
lalit-satapathy
left a comment
There was a problem hiding this comment.
code owner approval
|
Package aws_vpcflow_otel - 0.2.0 containing this change is available at https://epr.elastic.co/package/aws_vpcflow_otel/0.2.0/ |
8 participants
Updates to the OTel VPC Flow Log Dashboard + YAML version of dashboard leveraging https://github.com/strawgate/kb-yaml-to-lens
Removes _dev folder from content packs during build
Iterating on the actual panels here strawgate/kb-yaml-to-lens#914
Overview
Interface Analysis
Traffic Analysis
Current Dashboard on Main
The following is the dashboard on main that is being replaced
