Skip to content

Apache Otel Add SLO templates#17366

Closed
agithomas wants to merge 6 commits intoelastic:mainfrom
agithomas:issue-obs-intg-871
Closed

Apache Otel Add SLO templates#17366
agithomas wants to merge 6 commits intoelastic:mainfrom
agithomas:issue-obs-intg-871

Conversation

@agithomas
Copy link
Copy Markdown
Contributor

  • Enhancement

Proposed commit message

Add SLO template for Apache otel content pack

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • SLO configuration using SLO template

How to test this PR locally

elastic-package build && elastic-package stack up -v -d --services package-registry

Screenshots

image

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SLO template structure looks correct for format_version 3.5.0, but there are field name mismatches that will prevent the SLO from working correctly.

Field Name Issues:

The SLO template uses field names without the metrics. prefix, but the existing dashboard in this package uses the full field paths:

SLO Template Uses Dashboard Uses
apache.request.time metrics.apache.request.time
apache.requests metrics.apache.requests
apache.server.name resource.attributes.apache.server.name

These mismatches will cause the SLO to not find any data, resulting in 0% compliance or errors.

Please verify the actual field names in your Elasticsearch indices and update the SLO template to match. Looking at the dashboard file (kibana/dashboard/apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), the correct field names appear to include the prefixes.


Why is Claude responding? | Type @claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@andrewkroh andrewkroh added the Integration:apache_otel Apache OpenTelemetry Assets label Feb 11, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SLO template has field name mismatches that will prevent it from finding any data in Elasticsearch. All 5 issues were already flagged in the previous review and remain unaddressed:

  1. Metric field names (lines 15, 21, 27, 33): OTel metrics are indexed with a metrics. prefix. The fields should be:

    • metrics.apache.request.time instead of apache.request.time
    • metrics.apache.requests instead of apache.requests
  2. groupBy field (line 59): Server name uses a different path in OTel format:

    • resource.attributes.apache.server.name instead of apache.server.name

These field name mismatches are confirmed by examining the existing dashboard (apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), which correctly uses the metrics. prefix and resource.attributes. path.

Please address the suggestions in the existing inline comments.


Why is Claude responding? | Type @claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@agithomas
Copy link
Copy Markdown
Contributor Author

/test

@agithomas agithomas marked this pull request as ready for review February 18, 2026 12:55
@agithomas agithomas requested a review from a team as a code owner February 18, 2026 12:55
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Feb 18, 2026
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

@botelastic
Copy link
Copy Markdown

botelastic Bot commented Mar 25, 2026

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Mar 25, 2026
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Apr 24, 2026

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic Bot closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:apache_otel Apache OpenTelemetry Assets Stalled Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants