Conversation
There was a problem hiding this comment.
The SLO template structure looks correct for format_version 3.5.0, but there are field name mismatches that will prevent the SLO from working correctly.
Field Name Issues:
The SLO template uses field names without the metrics. prefix, but the existing dashboard in this package uses the full field paths:
| SLO Template Uses | Dashboard Uses |
|---|---|
apache.request.time |
metrics.apache.request.time |
apache.requests |
metrics.apache.requests |
apache.server.name |
resource.attributes.apache.server.name |
These mismatches will cause the SLO to not find any data, resulting in 0% compliance or errors.
Please verify the actual field names in your Elasticsearch indices and update the SLO template to match. Looking at the dashboard file (kibana/dashboard/apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), the correct field names appear to include the prefixes.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
The SLO template has field name mismatches that will prevent it from finding any data in Elasticsearch. All 5 issues were already flagged in the previous review and remain unaddressed:
-
Metric field names (lines 15, 21, 27, 33): OTel metrics are indexed with a
metrics.prefix. The fields should be:metrics.apache.request.timeinstead ofapache.request.timemetrics.apache.requestsinstead ofapache.requests
-
groupBy field (line 59): Server name uses a different path in OTel format:
resource.attributes.apache.server.nameinstead ofapache.server.name
These field name mismatches are confirmed by examining the existing dashboard (apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), which correctly uses the metrics. prefix and resource.attributes. path.
Please address the suggestions in the existing inline comments.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
|
/test |
💚 Build Succeeded
History
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
|
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Proposed commit message
Add SLO template for Apache otel content pack
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package build && elastic-package stack up -v -d --services package-registryScreenshots